Use elements/types in constants/values

Use elements/types in constants/values

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/58048f694e35af778cf54797bbe5b92718279a40

[Johnni Winther, 2017-01-10 14:31:42]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-11 22:57:47]

lgtm

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/helper...
File pkg/compiler/lib/src/helpers/debug_collection.dart (right):

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/helper...
pkg/compiler/lib/src/helpers/debug_collection.dart:74: Iterable<T> map<T>(T f(E
element)) => iterable.map(f);
:)

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/namer.dart (right):

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/namer.dart:1790:
codegenWorldBuilder.forEachInstanceField(constant.type.element,
interesting - correct me if I'm wrong, but I thought `namer` was invoked after
we are done with codegen (since we now know everything that was added to the
codegenworld and then we can figure out which names are are more frequent).

If so, this might be a motivation to move `forEachInstanceField` into closed
world and not pass the codegenWorldBuilder to the namer altogether.

WDTY?

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/constant_ordering.dart (right):

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/constant_ordering.dart:54: static int
compareDartTypes(ResolutionDartType a, ResolutionDartType b) {
this looks like a nice candidate to do next :)

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/patch_...
File pkg/compiler/lib/src/patch_parser.dart (right):

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/patch_...
pkg/compiler/lib/src/patch_parser.dart:468: .internalError(annotation, 'Invalid
@JS(...) annotation.');
sigh - no action for this CL, but we really need to move this out of this file.
It is something we will need with the new FE (while the rest of the patch parser
we won't need)

[Johnni Winther, 2017-01-12 11:17:45]

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/namer.dart (right):

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/namer.dart:1790:
codegenWorldBuilder.forEachInstanceField(constant.type.element,
On 2017/01/11 22:57:47, Siggi Cherem (dart-lang) wrote:
> interesting - correct me if I'm wrong, but I thought `namer` was invoked after
> we are done with codegen (since we now know everything that was added to the
> codegenworld and then we can figure out which names are are more frequent).
> 
> If so, this might be a motivation to move `forEachInstanceField` into closed
> world and not pass the codegenWorldBuilder to the namer altogether.
> 
> WDTY?
> 

I agree. We should create a ClosedWorld for codegen and pull it from there.
Adding a TODO.

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/constant_ordering.dart (right):

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/constant_ordering.dart:54: static int
compareDartTypes(ResolutionDartType a, ResolutionDartType b) {
On 2017/01/11 22:57:47, Siggi Cherem (dart-lang) wrote:
> this looks like a nice candidate to do next :)

Acknowledged.

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/patch_...
File pkg/compiler/lib/src/patch_parser.dart (right):

https://codereview.chromium.org/2620023002/diff/1/pkg/compiler/lib/src/patch_...
pkg/compiler/lib/src/patch_parser.dart:468: .internalError(annotation, 'Invalid
@JS(...) annotation.');
On 2017/01/11 22:57:47, Siggi Cherem (dart-lang) wrote:
> sigh - no action for this CL, but we really need to move this out of this
file.
> It is something we will need with the new FE (while the rest of the patch
parser
> we won't need)

Acknowledged.

[Johnni Winther, 2017-01-12 11:22:21]

Description was changed from

==========
Use elements/types in constants/values
==========

to

==========
Use elements/types in constants/values

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/58048f694e35af778cf54797bbe5b92718279a40
==========

[Johnni Winther, 2017-01-12 11:22:22]

Committed patchset #1 (id:1) manually as
58048f694e35af778cf54797bbe5b92718279a40 (presubmit successful).