Use elements/types in constants/values

pkg/compiler/lib/src/patch_parser.dart

Index: pkg/compiler/lib/src/patch_parser.dart
diff --git a/pkg/compiler/lib/src/patch_parser.dart b/pkg/compiler/lib/src/patch_parser.dart
index a356887dd3bc69ba8f959d11dfd057a140e4115e..bf2ae05b2bb9d1e60a1100713a392005c35b8e2f 100644
--- a/pkg/compiler/lib/src/patch_parser.dart
+++ b/pkg/compiler/lib/src/patch_parser.dart
@@ -462,8 +462,8 @@ class JsInteropAnnotationHandler implements EagerAnnotationHandler<bool> {
   void validate(Compiler compiler, Element element,
       MetadataAnnotation annotation, ConstantValue constant) {
     JavaScriptBackend backend = compiler.backend;
-    if (constant.getType(compiler.commonElements).element !=
-        backend.helpers.jsAnnotationClass) {
+    ResolutionDartType type = constant.getType(compiler.commonElements);
+    if (type.element != backend.helpers.jsAnnotationClass) {
       compiler.reporter
           .internalError(annotation, 'Invalid @JS(...) annotation.');

[Siggi Cherem (dart-lang), 2017/01/11 22:57:47]

sigh - no action for this CL, but we really need to move this out of this file.
It is something we will need with the new FE (while the rest of the patch parser
we won't need)

[Johnni Winther, 2017/01/12 11:17:45]

Acknowledged.

     }