Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2620013002: binding: Supports preparePrototypeAndInterfaceObject on partial interfaces. (Closed)

Created:
3 years, 11 months ago by Yuki
Modified:
3 years, 11 months ago
Reviewers:
haraken, xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, blink-reviews-bindings_chromium.org, blink-reviews, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Supports preparePrototypeAndInterfaceObject on partial interfaces. Supports V8<Type>Partial::preparePrototypeAndInterfaceObject. BUG= Review-Url: https://codereview.chromium.org/2620013002 Cr-Commit-Position: refs/heads/master@{#442846} Committed: https://chromium.googlesource.com/chromium/src/+/def6344468474881b7137a4593cc1d711d79e55d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Dropped a temporal IDL change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/templates/interface.h.tmpl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
xhwang
https://codereview.chromium.org/2620013002/diff/1/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.idl File third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.idl (right): https://codereview.chromium.org/2620013002/diff/1/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.idl#newcode8 third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.idl:8: [SecureContext, CallWith=ScriptState] Promise<MediaKeySystemAccess> requestMediaKeySystemAccess(DOMString keySystem, sequence<MediaKeySystemConfiguration> supportedConfigurations); Please do ...
3 years, 11 months ago (2017-01-10 17:47:02 UTC) #2
haraken
LGTM % dropping the change to modules/encryptedmedia.
3 years, 11 months ago (2017-01-10 23:36:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2620013002/20001
3 years, 11 months ago (2017-01-11 09:07:00 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:19:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/def6344468474881b7137a4593cc...

Powered by Google App Engine
This is Rietveld 408576698