Change the views sign-in dialog to be tab modal.

chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h

Index: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
diff --git a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
index 64c9e7533d4663389a33814dfa932d1d3f9ab775..98fac86b2bc380abac92d61d7b546f9f7d41190b 100644
--- a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
+++ b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
@@ -38,6 +38,7 @@ class SigninViewControllerDelegateViews : public views::DialogDelegateView,
       SigninViewController* signin_view_controller,
       std::unique_ptr<views::WebView> content_view,
       Browser* browser,
+      DialogModalType dialog_modal_type,
       bool wait_for_size);
 
   // Creates the web view that contains the signin flow in |mode| using
@@ -79,6 +80,10 @@ class SigninViewControllerDelegateViews : public views::DialogDelegateView,
   // content's size has been laid out and measured so that the constrained
   // window is sized to the content.
   bool wait_for_size_;
+

[jlebel, 2017/01/10 13:20:18]

 I would remove the empty line.

[msarda, 2017/01/10 17:32:27]

We prefer having a blank line if the comment starts at the same indentation as
the previous line (this is for code review tool).

+  // The dialog modal presentation type.

[Peter Kasting, 2017/01/11 01:24:45]

Nit: I agree with your rationale on adding blank lines due to comments -- but I
think this comment adds little to the code, so I'd just remove it (and then
remove the blank lines above and below.

[msarda, 2017/01/11 09:54:25]

Done.

+  DialogModalType dialog_modal_type_;
+

[jlebel, 2017/01/10 13:20:18]

Same here.

[msarda, 2017/01/10 17:32:27]

Ditto.

   Browser* browser_;
 
   DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegateViews);