Change the views sign-in dialog to be tab modal.

chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_VIEWS_H_
 
 #include "base/macros.h"
 #include "chrome/browser/ui/profile_chooser_constants.h"
 #include "chrome/browser/ui/signin_view_controller_delegate.h"
@@ skipping 20 matching lines @@
 class SigninViewControllerDelegateViews : public views::DialogDelegateView,
                                           public SigninViewControllerDelegate {
  public:
   // Creates and displays a constrained window containing |web_contents|. If
   // |wait_for_size| is true, the delegate will wait for ResizeNativeView() to
   // be called by the base class before displaying the constrained window.
   SigninViewControllerDelegateViews(
       SigninViewController* signin_view_controller,
       std::unique_ptr<views::WebView> content_view,
       Browser* browser,
+      DialogModalType dialog_modal_type,
       bool wait_for_size);
 
   // Creates the web view that contains the signin flow in |mode| using
   // |profile| as the web content's profile, then sets |delegate| as the created
   // web content's delegate.
   static std::unique_ptr<views::WebView> CreateGaiaWebView(
       content::WebContentsDelegate* delegate,
       profiles::BubbleViewMode mode,
       Browser* browser,
       signin_metrics::AccessPoint access_point);
@@ skipping 21 matching lines @@
 
   ~SigninViewControllerDelegateViews() override;
 
   views::WebView* content_view_;
   views::Widget* modal_signin_widget_;  // Not owned.
 
   // wait_for_size_ stores whether the dialog should only be shown after its
   // content's size has been laid out and measured so that the constrained
   // window is sized to the content.
   bool wait_for_size_;
+

[jlebel, 2017/01/10 13:20:18]

 I would remove the empty line.

[msarda, 2017/01/10 17:32:27]

We prefer having a blank line if the comment starts at the same indentation as
the previous line (this is for code review tool).

+  // The dialog modal presentation type.

[Peter Kasting, 2017/01/11 01:24:45]

Nit: I agree with your rationale on adding blank lines due to comments -- but I
think this comment adds little to the code, so I'd just remove it (and then
remove the blank lines above and below.

[msarda, 2017/01/11 09:54:25]

Done.

+  DialogModalType dialog_modal_type_;
+

[jlebel, 2017/01/10 13:20:18]

Same here.

[msarda, 2017/01/10 17:32:27]

Ditto.

   Browser* browser_;
 
   DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegateViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_VIEWS_H_