Improve performance of access-key-for-all-elements.html.

Improve performance of access-key-for-all-elements.html.

- Compute 'modifiers' just once
- Remove unsupported elements
- Convert to testharness.js

Time to complete the test with Windows Debug build:
11.8sec -> 1.6sec

BUG=678346
Review-Url: https://codereview.chromium.org/2619963002
Cr-Commit-Position: refs/heads/master@{#442524}
Committed: https://chromium.googlesource.com/chromium/src/+/7a7dee0d2d921c83a17984b143d8b1988f49c93a

[tkent, 2017-01-10 01:34:49]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:35:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-01-10 01:36:28]

Description was changed from

==========
Improve performance of access-key-for-all-elements.html.

- Remove unsupported elements
- Convert to testharness.js

Windows Debug build:
11.8sec -> 1.6sec

BUG=678346
==========

to

==========
Improve performance of access-key-for-all-elements.html.

- Compute 'modifiers' just once
- Remove unsupported elements
- Convert to testharness.js

Windows Debug build:
11.8sec -> 1.6sec

BUG=678346
==========

[tkent, 2017-01-10 01:46:54]

Description was changed from

==========
Improve performance of access-key-for-all-elements.html.

- Compute 'modifiers' just once
- Remove unsupported elements
- Convert to testharness.js

Windows Debug build:
11.8sec -> 1.6sec

BUG=678346
==========

to

==========
Improve performance of access-key-for-all-elements.html.

- Compute 'modifiers' just once
- Remove unsupported elements
- Convert to testharness.js

Time to complete the test with Windows Debug build:
11.8sec -> 1.6sec

BUG=678346
==========

[commit-bot: I haz the power, 2017-01-10 03:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:37:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[tkent, 2017-01-10 03:39:32]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2017-01-10 03:39:32]

kochi@, would you review this please?

[kochi, 2017-01-10 03:53:31]

LGTM

nits are mostly matter of style preference, and feel free
to ignore.

https://codereview.chromium.org/2619963002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/forms/access-key-for-all-elements.html
(right):

https://codereview.chromium.org/2619963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/access-key-for-all-elements.html:6:
var modifiers;
nit: maybe 'use strict'; ?

https://codereview.chromium.org/2619963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/access-key-for-all-elements.html:6:
var modifiers;
nit: how about using 'const' instead of 'var'?

https://codereview.chromium.org/2619963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/access-key-for-all-elements.html:8:
modifiers = ["ctrlKey", "altKey"];
nit: looks like this file contains both 2 and 4 tabs.

https://codereview.chromium.org/2619963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/access-key-for-all-elements.html:25:
for (var i = 0 ; i < tagNames.length; i++) {
nit: tagNames.forEach((name) => {...}); ?

[tkent, 2017-01-10 05:15:53]

https://codereview.chromium.org/2619963002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/fast/forms/access-key-for-all-elements.html
(right):

https://codereview.chromium.org/2619963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/access-key-for-all-elements.html:6:
var modifiers;
On 2017/01/10 at 03:53:31, kochi wrote:
> nit: how about using 'const' instead of 'var'?

Done

https://codereview.chromium.org/2619963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/access-key-for-all-elements.html:8:
modifiers = ["ctrlKey", "altKey"];
On 2017/01/10 at 03:53:31, kochi wrote:
> nit: looks like this file contains both 2 and 4 tabs.

Done.

https://codereview.chromium.org/2619963002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/forms/access-key-for-all-elements.html:25:
for (var i = 0 ; i < tagNames.length; i++) {
On 2017/01/10 at 03:53:31, kochi wrote:
> nit: tagNames.forEach((name) => {...}); ?

Done.

[tkent, 2017-01-10 05:15:57]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-01-10 05:15:57]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2619963002/#ps20001
(title: "Follow review comments")

[commit-bot: I haz the power, 2017-01-10 05:16:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 07:29:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484025357232630,
"parent_rev": "50b51c228aac6489fe29c744d8140ee20ab62f8d", "commit_rev":
"7a7dee0d2d921c83a17984b143d8b1988f49c93a"}

[commit-bot: I haz the power, 2017-01-10 07:29:43]

Description was changed from

==========
Improve performance of access-key-for-all-elements.html.

- Compute 'modifiers' just once
- Remove unsupported elements
- Convert to testharness.js

Time to complete the test with Windows Debug build:
11.8sec -> 1.6sec

BUG=678346
==========

to

==========
Improve performance of access-key-for-all-elements.html.

- Compute 'modifiers' just once
- Remove unsupported elements
- Convert to testharness.js

Time to complete the test with Windows Debug build:
11.8sec -> 1.6sec

BUG=678346

Review-Url: https://codereview.chromium.org/2619963002
Cr-Commit-Position: refs/heads/master@{#442524}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a7dee0d2d921c83a17984b143d8...
==========

[commit-bot: I haz the power, 2017-01-10 07:29:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a7dee0d2d921c83a17984b143d8...