Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2619953002: [ash-md] Updates slider control to show thumb highlight when focused (Closed)

Created:
3 years, 11 months ago by varkha
Modified:
3 years, 11 months ago
Reviewers:
tdanderson, sadrul
CC:
chromium-reviews, kalyank, sadrul, tfarina, yiyix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Updates slider control to show thumb highlight when focused Makes the thumb highlighted when the slider control is focused helping when controlling volume or brightness with a keyboard. BUG=658783 Review-Url: https://codereview.chromium.org/2619953002 Cr-Commit-Position: refs/heads/master@{#442816} Committed: https://chromium.googlesource.com/chromium/src/+/46a10c19dab82172fb82578b062b8929600cf376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ash/common/system/tray/tray_popup_utils.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/md_slider.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
varkha
tdanderson@, can you please take a first look? Thanks!
3 years, 11 months ago (2017-01-10 01:00:18 UTC) #4
tdanderson
LGTM
3 years, 11 months ago (2017-01-10 22:33:04 UTC) #7
varkha
+sadrul@ for OWNERS in ui/views/controls/. Thanks!
3 years, 11 months ago (2017-01-10 22:40:12 UTC) #9
sadrul
lgtm
3 years, 11 months ago (2017-01-11 02:47:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619953002/1
3 years, 11 months ago (2017-01-11 05:02:38 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 05:49:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46a10c19dab82172fb82578b062b...

Powered by Google App Engine
This is Rietveld 408576698