arc: rename GetInstanceForVersion

arc: rename GetInstanceForVersion

to GetInstanceForVersionDoNotCallDirectly so developers will
always use ARC_GET_INSTANCE_FOR_METHOD instead.

BUG=649782
TEST=try

Review-Url: https://codereview.chromium.org/2619843002
Cr-Commit-Position: refs/heads/master@{#442317}
Committed: https://chromium.googlesource.com/chromium/src/+/74c6655efd699fabfbf40856e2d6717f273812f5

[Yusuke Sato, 2017-01-09 18:35:46]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 18:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-01-09 18:39:20]

yusukes@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Yusuke Sato, 2017-01-09 18:39:20]

PTAL

[Luis Héctor Chávez, 2017-01-09 18:41:02]

lgtm but please change the comment.

https://codereview.chromium.org/2619843002/diff/1/components/arc/instance_hol...
File components/arc/instance_holder.h (right):

https://codereview.chromium.org/2619843002/diff/1/components/arc/instance_hol...
components/arc/instance_holder.h:17: // A convenience macro to call
This is now not a convenience macro, but the only way to do so :)

[commit-bot: I haz the power, 2017-01-09 19:08:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 19:08:20]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2017-01-09 19:10:31]

https://codereview.chromium.org/2619843002/diff/1/components/arc/instance_hol...
File components/arc/instance_holder.h (right):

https://codereview.chromium.org/2619843002/diff/1/components/arc/instance_hol...
components/arc/instance_holder.h:17: // A convenience macro to call
On 2017/01/09 18:41:02, Luis Héctor Chávez wrote:
> This is now not a convenience macro, but the only way to do so :)

Done.

[Yusuke Sato, 2017-01-09 19:10:36]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2017-01-09 19:10:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2619843002/#ps20001
(title: "fix comment")

[commit-bot: I haz the power, 2017-01-09 19:11:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:46:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483989036033220,
"parent_rev": "bfe9b5159ea0b5372fb482b8649637b0e7e450f8", "commit_rev":
"74c6655efd699fabfbf40856e2d6717f273812f5"}

[commit-bot: I haz the power, 2017-01-09 19:46:38]

Description was changed from

==========
arc: rename GetInstanceForVersion

to GetInstanceForVersionDoNotCallDirectly so developers will
always use ARC_GET_INSTANCE_FOR_METHOD instead.

BUG=649782
TEST=try
==========

to

==========
arc: rename GetInstanceForVersion

to GetInstanceForVersionDoNotCallDirectly so developers will
always use ARC_GET_INSTANCE_FOR_METHOD instead.

BUG=649782
TEST=try

Review-Url: https://codereview.chromium.org/2619843002
Cr-Commit-Position: refs/heads/master@{#442317}
Committed:
https://chromium.googlesource.com/chromium/src/+/74c6655efd699fabfbf40856e2d6...
==========

[commit-bot: I haz the power, 2017-01-09 19:46:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/74c6655efd699fabfbf40856e2d6...