Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2619823005: [ic][stubs] Move more IC-related methods from CSA to AccessorAssembler. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic][stubs] Move more IC-related methods from CSA to AccessorAssembler. ... and reshuffle it a bit. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2619823005 Cr-Commit-Position: refs/heads/master@{#42185} Committed: https://chromium.googlesource.com/v8/v8/+/de2422723435b0a35bbea93fa42fb07ddfed0109

Patch Set 1 : Code move #

Total comments: 2

Patch Set 2 : Code reshuffling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -147 lines) Patch
M src/code-stub-assembler.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/code-stub-assembler.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M src/ic/accessor-assembler.cc View 1 4 chunks +125 lines, -32 lines 0 comments Download
M src/ic/accessor-assembler-impl.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/ic/handler-configuration-inl.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/keyed-store-generic.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Igor Sheludko
PTAL https://codereview.chromium.org/2619823005/diff/20001/src/ic/accessor-assembler.cc File src/ic/accessor-assembler.cc (right): https://codereview.chromium.org/2619823005/diff/20001/src/ic/accessor-assembler.cc#newcode673 src/ic/accessor-assembler.cc:673: // Generate full field type check here and ...
3 years, 11 months ago (2017-01-10 15:11:13 UTC) #4
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-10 15:23:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619823005/40001
3 years, 11 months ago (2017-01-10 15:42:53 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 15:45:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/de2422723435b0a35bbea93fa42fb07ddfe...

Powered by Google App Engine
This is Rietveld 408576698