Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2619823002: Roll buildtools 0ef8010876..7e08d331f1 (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 0ef8010876..7e08d331f1 In order to roll GN c99acd6557..5c18ca83ce (r439377:r442253) and pick up the following changes: 4ce240b3ecb8 Associate xctest files with corresponding xctest targets. 7e5894a9a070 Configure xctest build settings to prevent Xcode from linking objects. 043a15ddcc6c Add functionality to find xctest files under application target. d1316080967d Stop propagation of dependent configs between toolchains. 0c1dd9de8c00 GN: Fix some typos in the documentation. 67e8c60e4b18 [Refactor Xcode Objects] Allow extra attributes for native targets. 8fb7d9d9c9dd [Refactor Xcode Objects] Enable adding per file '--help' compiler flag. 898a56b7966c [Refactor Xcode Objects] Decouple file references and indexing target. a8936b7a13ff Fix a typo in GN documentation 889ccd0f81e2 Fix a typo in gn help. 7d88638248b1 Support for source_target_relative expansion in GN 615f852746f6 Fix GN bootstrap. d48f4812d853 [Refactor Xcode Objects] Enable navigator paths for file references. 44dbd2f12ae5 Clean up link references in //tools/gn/README.md. TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2619823002 Cr-Commit-Position: refs/heads/master@{#442988} Committed: https://chromium.googlesource.com/chromium/src/+/b61b264655a67b06dd3937ba02e7b487cc35aacd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
sdefresne
3 years, 11 months ago (2017-01-09 16:53:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619823002/1
3 years, 11 months ago (2017-01-09 16:54:21 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/133496)
3 years, 11 months ago (2017-01-09 17:02:38 UTC) #5
Dirk Pranke
lgtm. I think there's something weird going on on the ios builders; I saw this ...
3 years, 11 months ago (2017-01-09 17:38:20 UTC) #6
sdefresne
Looks like ios is not happy because of what I assume is https://bugs.chromium.org/p/chromium/issues/detail?id=675224.
3 years, 11 months ago (2017-01-09 17:38:23 UTC) #7
Dirk Pranke
On 2017/01/09 17:38:23, sdefresne wrote: > Looks like ios is not happy because of what ...
3 years, 11 months ago (2017-01-09 17:43:06 UTC) #8
sdefresne
On 2017/01/09 17:43:06, Dirk Pranke wrote: > On 2017/01/09 17:38:23, sdefresne wrote: > > Looks ...
3 years, 11 months ago (2017-01-11 16:52:01 UTC) #9
sdefresne
On 2017/01/11 16:52:01, sdefresne wrote: > On 2017/01/09 17:43:06, Dirk Pranke wrote: > > On ...
3 years, 11 months ago (2017-01-11 18:53:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619823002/1
3 years, 11 months ago (2017-01-11 18:54:37 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 20:44:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b61b264655a67b06dd3937ba02e7...

Powered by Google App Engine
This is Rietveld 408576698