Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2619813002:
[ios] Updates test_runner.py to output a test results json file. (Closed)
|
Created:
3 years, 11 months ago by rohitrao (ping after 24h) Modified:
3 years, 11 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ios] Updates test_runner.py to output a test results json file.
BUG=678828
Review-Url: https://codereview.chromium.org/2619813002
Cr-Commit-Position: refs/heads/master@{#442668}
Committed: https://chromium.googlesource.com/chromium/src/+/8eb71cdc6259464bee1640d4acdefb9638088e40
Patch Set 1 #
Total comments: 2
Patch Set 2 : Unordered dict. #
Total comments: 6
Patch Set 3 : Fixes. #
Messages
Total messages: 26 (18 generated)
The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rohitrao@chromium.org changed reviewers: + smut@google.com
Rough draft to start the conversation. It seemed easier to create a new file than to try handling all of the various extra fields (crash logs, etc) that are in the current summary.json file. This is pretty straightforward, and it's only really missing the running time for each test. Do we have access to the gtest-generated json summary file? Or do we just parse the log output to determine whether a test passed or failed? If we have access to the gtest json, we could just use that directly. The recipe will need to be updated to call upload_test_results.py and append some buildbot-specific metadata.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2619813002/diff/1/ios/build/bots/scripts/test... File ios/build/bots/scripts/test_runner.py (right): https://codereview.chromium.org/2619813002/diff/1/ios/build/bots/scripts/test... ios/build/bots/scripts/test_runner.py:181: self.test_results = collections.OrderedDict() Does order matter?
https://codereview.chromium.org/2619813002/diff/1/ios/build/bots/scripts/test... File ios/build/bots/scripts/test_runner.py (right): https://codereview.chromium.org/2619813002/diff/1/ios/build/bots/scripts/test... ios/build/bots/scripts/test_runner.py:181: self.test_results = collections.OrderedDict() On 2017/01/09 21:16:12, smut wrote: > Does order matter? Nope. I was originally trying to match what summary.json does, but that's no longer important since I'm not yet attempting to merge the two files.
The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lpromero@chromium.org changed reviewers: + lpromero@chromium.org
https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... File ios/build/bots/scripts/run.py (right): https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... ios/build/bots/scripts/run.py:77: Maybe remove this new line, and add one before if tr:? https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... File ios/build/bots/scripts/test_runner.py (right): https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... ios/build/bots/scripts/test_runner.py:359: # Build test_results.json Add a period. https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... ios/build/bots/scripts/test_runner.py:364: } Is this indent correct?
The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... File ios/build/bots/scripts/run.py (right): https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... ios/build/bots/scripts/run.py:77: On 2017/01/10 14:34:04, lpromero wrote: > Maybe remove this new line, and add one before if tr:? Done. https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... File ios/build/bots/scripts/test_runner.py (right): https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... ios/build/bots/scripts/test_runner.py:359: # Build test_results.json On 2017/01/10 14:34:04, lpromero wrote: > Add a period. Done. https://codereview.chromium.org/2619813002/diff/20001/ios/build/bots/scripts/... ios/build/bots/scripts/test_runner.py:364: } On 2017/01/10 14:34:04, lpromero wrote: > Is this indent correct? Not sure, moved it out two.
lgtm to the best of my knowledge.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rohitrao@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from smut@google.com Link to the patchset: https://codereview.chromium.org/2619813002/#ps40001 (title: "Fixes.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484078981264470,
"parent_rev": "5babfd313562ebd60a9a7910912a764bed6d63c0", "commit_rev":
"8eb71cdc6259464bee1640d4acdefb9638088e40"}
Message was sent while issue was closed.
Description was changed from ========== [ios] Updates test_runner.py to output a test results json file. BUG=678828 ========== to ========== [ios] Updates test_runner.py to output a test results json file. BUG=678828 Review-Url: https://codereview.chromium.org/2619813002 Cr-Commit-Position: refs/heads/master@{#442668} Committed: https://chromium.googlesource.com/chromium/src/+/8eb71cdc6259464bee1640d4acde... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/8eb71cdc6259464bee1640d4acde... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
