Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 2619803003: Revert of ONC: Fix handling of invalid proxy scheme. (Closed)

Created:
3 years, 11 months ago by Timothy Loh
Modified:
3 years, 11 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ONC: Fix handling of invalid proxy scheme. (patchset #4 id:60001 of https://codereview.chromium.org/2608803002/ ) Reason for revert: The modified test is failing on Linux ChromiumOS Tests (dbg)(1) https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 An example failure: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/21284/steps/chromeos_unittests/logs/stdio Original issue's description: > ONC: Fix handling of invalid proxy scheme. > > It is common for a proxy configuration URL to be added as 'foo.com' > instead of 'http://foo.com'. Rather than relying on all UI to > validate the input, we should do so in the ONC conversion. > > BUG=677357 > > Review-Url: https://codereview.chromium.org/2608803002 > Cr-Commit-Position: refs/heads/master@{#442378} > Committed: https://chromium.googlesource.com/chromium/src/+/a8a349eb13605f30e1aa6c096f4c4ea28ba11bc9 TBR=emaxx@chromium.org,mnissler@chromium.org,pkasting@chromium.org,stevenjb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=677357 Review-Url: https://codereview.chromium.org/2619803003 Cr-Commit-Position: refs/heads/master@{#442458} Committed: https://chromium.googlesource.com/chromium/src/+/23a69173a82474bd2981f5f75766e37f75ebbfb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -35 lines) Patch
M chromeos/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_utils.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chromeos/network/onc/onc_utils_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D chromeos/test/data/network/proxy_config_from_onc.json View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Timothy Loh
Created Revert of ONC: Fix handling of invalid proxy scheme.
3 years, 11 months ago (2017-01-10 02:50:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619803003/1
3 years, 11 months ago (2017-01-10 02:51:22 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 03:01:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/23a69173a82474bd2981f5f75766...

Powered by Google App Engine
This is Rietveld 408576698