Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2619763002: Expose local sync mode status in the chrome://sync-internals page. (Closed)

Created:
3 years, 11 months ago by pastarmovj
Modified:
3 years, 11 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose local sync mode status in the chrome://sync-internals page. Shows whether the local sync backend has been enabled and where the database for it is stored if it is enabled. BUG=668145 TEST=manual Review-Url: https://codereview.chromium.org/2619763002 Cr-Commit-Position: refs/heads/master@{#442537} Committed: https://chromium.googlesource.com/chromium/src/+/ea1b4f5cfba38034eadfced04ce0906ef193f9a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M components/sync/driver/about_sync_util.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M components/sync/engine/sync_status.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/engine_impl/all_status.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync/engine_impl/all_status.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pastarmovj
Hi Pavel, Happy new year! I added two new lines to the sync-internals page to ...
3 years, 11 months ago (2017-01-09 11:09:46 UTC) #2
pavely
lgtm
3 years, 11 months ago (2017-01-09 19:42:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619763002/1
3 years, 11 months ago (2017-01-10 08:32:03 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 09:18:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea1b4f5cfba38034eadfced04ce0...

Powered by Google App Engine
This is Rietveld 408576698