Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2619743002: [build] Exclude stand-alone targets when built with chromium

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Exclude stand-alone targets when built with chromium BUG=chromium:671829

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -77 lines) Patch
M BUILD.gn View 3 chunks +86 lines, -77 lines 1 comment Download

Messages

Total messages: 11 (5 generated)
Michael Achenbach
PTAL
3 years, 11 months ago (2017-01-09 08:07:28 UTC) #2
Michael Achenbach
https://codereview.chromium.org/2619743002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2619743002/diff/1/BUILD.gn#newcode2624 BUILD.gn:2624: deps += [ "//third_party/icu" ] The following 50 lines ...
3 years, 11 months ago (2017-01-09 08:09:31 UTC) #5
jochen (gone - plz use gerrit)
hum, not sure. I'd like to move towards a world where we can develop v8 ...
3 years, 11 months ago (2017-01-09 08:18:06 UTC) #6
Michael Achenbach
On 2017/01/09 08:18:06, jochen wrote: > hum, not sure. I'd like to move towards a ...
3 years, 11 months ago (2017-01-09 08:19:33 UTC) #7
jochen (gone - plz use gerrit)
let me comment on the bug
3 years, 11 months ago (2017-01-09 08:25:46 UTC) #8
Michael Achenbach
3 years, 11 months ago (2017-01-09 08:29:22 UTC) #11
On 2017/01/09 08:25:46, jochen wrote:
> let me comment on the bug

Thanks, as a compromise, we could also only exclude the simple fuzzer targets.
They only exist because we don't have libfuzzer in v8. In a chromium build we
have the real targets already. Also, those seem to grow in number without
bounds...

Powered by Google App Engine
This is Rietveld 408576698