Issue 261973002: Blink GC plugin: require that GC derived classes do not override their new(size_t) operator.

Issue 261973002: Blink GC plugin: require that GC derived classes do not override their new(size_t) operator. (Closed)

Created:
6 years, 7 months ago by zerny-chromium

Modified:
6 years, 7 months ago

Reviewers:
wibling-chromium

CC:
chromium-reviews, oilpan-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Blink GC plugin: require that GC derived classes do not override their new(size_t) operator. BUG=334149 R=wibling@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268164

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -7 lines)			Patch
M	tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp	View		5 chunks	+17 lines, -0 lines	0 comments	Download
M	tools/clang/blink_gc_plugin/RecordInfo.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/clang/blink_gc_plugin/RecordInfo.cpp	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A +	tools/clang/blink_gc_plugin/tests/class_overrides_new.h	View		1 chunk	+4 lines, -6 lines	0 comments	Download
A +	tools/clang/blink_gc_plugin/tests/class_overrides_new.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tools/clang/blink_gc_plugin/tests/class_overrides_new.txt	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/clang/blink_gc_plugin/tests/heap/stubs.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

zerny-chromium

Changed the check to only disallow declaring new(size_t). This permits the declaration of new(size_t, void*) ...

6 years, 7 months ago (2014-05-05 08:37:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/261973002/20001

6 years, 7 months ago (2014-05-05 09:28:33 UTC) #6

Message was sent while issue was closed.

Change committed as 268164