Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_overrides_new.h

Issue 261973002: Blink GC plugin: require that GC derived classes do not override their new(size_t) operator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: only check new(size_t) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_overrides_new.h
diff --git a/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.h b/tools/clang/blink_gc_plugin/tests/class_overrides_new.h
similarity index 62%
copy from tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.h
copy to tools/clang/blink_gc_plugin/tests/class_overrides_new.h
index 0e1c81516ce8ed9d986bb220cb9536225f14a417..c76daef5e5c2a0b465aed1ebf36e8624c33cefc1 100644
--- a/tools/clang/blink_gc_plugin/tests/destructor_in_nonfinalized_class.h
+++ b/tools/clang/blink_gc_plugin/tests/class_overrides_new.h
@@ -2,19 +2,17 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef DESTRUCTOR_IN_NONFINALIZED_CLASS_H_
-#define DESTRUCTOR_IN_NONFINALIZED_CLASS_H_
+#ifndef CLASS_OVERRIDES_NEW_H_
+#define CLASS_OVERRIDES_NEW_H_
#include "heap/stubs.h"
namespace WebCore {
class HeapObject : public GarbageCollected<HeapObject> {
+ WTF_MAKE_FAST_ALLOCATED;
public:
- ~HeapObject();
- void trace(Visitor*);
-private:
- Member<HeapObject> m_obj;
+ void trace(Visitor*) { }
};
}
« no previous file with comments | « tools/clang/blink_gc_plugin/RecordInfo.cpp ('k') | tools/clang/blink_gc_plugin/tests/class_overrides_new.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698