Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2619663002: Add a new rappor metric to record all package names excluding GSA (Closed)

Created:
3 years, 11 months ago by Yusuf
Modified:
3 years, 10 months ago
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new rappor metric to record all package names excluding GSA BUG=679085 Review-Url: https://codereview.chromium.org/2619663002 Cr-Commit-Position: refs/heads/master@{#442694} Committed: https://chromium.googlesource.com/chromium/src/+/63f9112d35ca0514c9eab4b8bc538f277a6343b0

Patch Set 1 #

Patch Set 2 : FB fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAState.java View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Ted C
lgtm
3 years, 11 months ago (2017-01-10 18:32:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619663002/1
3 years, 11 months ago (2017-01-10 18:47:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/191512)
3 years, 11 months ago (2017-01-10 19:46:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619663002/20001
3 years, 11 months ago (2017-01-10 20:15:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/63f9112d35ca0514c9eab4b8bc538f277a6343b0
3 years, 11 months ago (2017-01-10 21:29:36 UTC) #13
Wez
Hallo rkaplow@chromium.org! Due to a depot_tools patch which mistakenly removed the OWNERS check for non-source ...
3 years, 10 months ago (2017-02-07 02:30:31 UTC) #15
Wez
Really add rkaplow@chromium.org this time.
3 years, 10 months ago (2017-02-08 00:14:37 UTC) #19
Steven Holte
3 years, 10 months ago (2017-02-08 00:30:23 UTC) #21
Message was sent while issue was closed.
rappor lgtm

Powered by Google App Engine
This is Rietveld 408576698