Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2619643002: [Downloads] Re-add notification namespace (Closed)

Created:
3 years, 11 months ago by gone
Modified:
3 years, 11 months ago
Reviewers:
qinmin
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Re-add notification namespace The namespace accidentally got removed while experimenting with a fix for notification grouping. BUG=678694 Review-Url: https://codereview.chromium.org/2619643002 Cr-Commit-Position: refs/heads/master@{#442070} Committed: https://chromium.googlesource.com/chromium/src/+/4333928031cee6b8ff32d2fcddd45d537f7ea500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
gone
3 years, 11 months ago (2017-01-06 21:46:37 UTC) #4
qinmin
lgtm
3 years, 11 months ago (2017-01-06 21:49:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619643002/1
3 years, 11 months ago (2017-01-06 22:03:50 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 22:17:19 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4333928031cee6b8ff32d2fcddd4...

Powered by Google App Engine
This is Rietveld 408576698