Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2619573002: Use a raster SkImage in DragImageBuilder (Closed)

Created:
3 years, 11 months ago by f(malita)
Modified:
3 years, 11 months ago
Reviewers:
reed1
CC:
chromium-reviews, blink-reviews, Brian Osman, msarett1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a raster SkImage in DragImageBuilder DragImageBuilder is currently instantiating a picture-backed SkImage. But there is no advantage to that, because DragImage::create() is immediately rasterizing it (via SkImage::asLegacyBitmap). Since we're trying to reduce the use of picture-backed images in Blink, refactor to rasterize upfront. R=reed@google.com BUG=skia:6100 Review-Url: https://codereview.chromium.org/2619573002 Cr-Commit-Position: refs/heads/master@{#442039} Committed: https://chromium.googlesource.com/chromium/src/+/bef18d10d18bd46e0c8dce3e8ece1176cdfec9fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
f(malita)
3 years, 11 months ago (2017-01-06 18:29:14 UTC) #3
reed1
lgtm
3 years, 11 months ago (2017-01-06 18:39:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619573002/1
3 years, 11 months ago (2017-01-06 18:40:43 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 20:47:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bef18d10d18bd46e0c8dce3e8ece...

Powered by Google App Engine
This is Rietveld 408576698