Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2619543002: Use a new Supplement constructor in ServiceWorkerContainer (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, haraken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a new Supplement constructor in ServiceWorkerContainer We're deprecating the default constructor of Supplement. BUG=610176 Review-Url: https://codereview.chromium.org/2619543002 Cr-Commit-Position: refs/heads/master@{#441922} Committed: https://chromium.googlesource.com/chromium/src/+/1f60b0e8ae55963b672590b2793d4829483ceea9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.h View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp View 4 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-06 09:57:15 UTC) #2
sof
lgtm
3 years, 11 months ago (2017-01-06 10:15:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619543002/1
3 years, 11 months ago (2017-01-06 10:17:07 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 11:57:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f60b0e8ae55963b672590b2793d...

Powered by Google App Engine
This is Rietveld 408576698