Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2619533002: tools/clang/scripts/update.py: remove deprecated --tools flag (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org, nasko, Ɓukasz Anforowicz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/clang/scripts/update.py: remove deprecated --tools flag This is just an alias for --extra-tools, and all affected buildbots have been updated to not use this flag. BUG=none R=danakj@chromium.org Review-Url: https://codereview.chromium.org/2619533002 Cr-Commit-Position: refs/heads/master@{#441957} Committed: https://chromium.googlesource.com/chromium/src/+/27c3ece209d8ecddd39fd4331373072e0fba9688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
dcheng
3 years, 11 months ago (2017-01-06 07:00:30 UTC) #1
Nico
Lgtm (But things spanning more than one cl should have tracking bug. Too late.)
3 years, 11 months ago (2017-01-06 12:20:50 UTC) #3
danakj
LGTM
3 years, 11 months ago (2017-01-06 15:15:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619533002/1
3 years, 11 months ago (2017-01-06 15:16:00 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 17:14:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27c3ece209d8ecddd39fd4331373...

Powered by Google App Engine
This is Rietveld 408576698