Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2619523003: Remove isGlobalInitialized (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
kouhei (in TOK), Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove isGlobalInitialized Now it's unused. We can remove it. BUG=677253 Review-Url: https://codereview.chromium.org/2619523003 Cr-Commit-Position: refs/heads/master@{#441906} Committed: https://chromium.googlesource.com/chromium/src/+/efc489008d2094b83736b130cb8f5349ff0c4309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-06 07:28:54 UTC) #2
kouhei (in TOK)
lgtm
3 years, 11 months ago (2017-01-06 07:32:07 UTC) #4
Yuki
LGTM!
3 years, 11 months ago (2017-01-06 07:36:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619523003/1
3 years, 11 months ago (2017-01-06 07:36:38 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 09:09:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/efc489008d2094b83736b130cb8f...

Powered by Google App Engine
This is Rietveld 408576698