Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 2619493005: Harmonize SpdyFrameType enum values with wire values. (Closed)

Created:
3 years, 11 months ago by Bence
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Harmonize SpdyFrameType enum values with wire values. Also change ParseFrameType() return value for invalid frame types. This does not matter in SpdyFramer::ValidateFrameHeader(), because the call to ParseFrameType() is preceeded by a call to IsValidFrameType(). This CL lands server change 143677028 by bnc. BUG=488484 Review-Url: https://codereview.chromium.org/2619493005 Cr-Commit-Position: refs/heads/master@{#442903} Committed: https://chromium.googlesource.com/chromium/src/+/118fbb95fe6d8033390fc2041900df982192826d

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -58 lines) Patch
M net/spdy/spdy_protocol.h View 1 chunk +15 lines, -13 lines 0 comments Download
M net/spdy/spdy_protocol.cc View 1 chunk +4 lines, -45 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Bence
Ryan: PTAL. Thank you.
3 years, 11 months ago (2017-01-06 19:40:52 UTC) #6
Ryan Hamilton
lgtm
3 years, 11 months ago (2017-01-10 22:47:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619493005/20001
3 years, 11 months ago (2017-01-11 14:04:44 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 15:02:06 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/118fbb95fe6d8033390fc2041900...

Powered by Google App Engine
This is Rietveld 408576698