Let the canonical name of invalid encoding be an empty string

Let the canonical name of invalid encoding be an empty string

Returning nullptr caused crash in fuzz testing when the call sites 
attempts to create a string object out of it. Previously it was
returning an empty string(std::string()). This change makes it work
as it used to by changing the return type back to std::string.

BUG=678359
Review-Url: https://codereview.chromium.org/2619493002
Cr-Commit-Position: refs/heads/master@{#441904}
Committed: https://chromium.googlesource.com/chromium/src/+/8e9a8aabbde296324fa081995177dd5aac5622e4

[Jinsuk Kim, 2017-01-06 01:52:51]

Description was changed from

==========
Let the canonical name of invalid encoding be empty string

Returning nullptr causes crash when the call sites attempts
to create a string object out of it. Previously it was returing
empty string(std::string()). This change makes it work as
it used to by returning a string literal.

BUG=678359
==========

to

==========
Let the canonical name of invalid encoding be empty string

Returning nullptr caused crash in fuzz testing when the call sites 
attempts to create a string object out of it. Previously it was
returning an empty string(std::string()). This change makes it work
as it used to by returning a string literal.

BUG=678359
==========

[Jinsuk Kim, 2017-01-06 01:54:13]

Description was changed from

==========
Let the canonical name of invalid encoding be empty string

Returning nullptr caused crash in fuzz testing when the call sites 
attempts to create a string object out of it. Previously it was
returning an empty string(std::string()). This change makes it work
as it used to by returning a string literal.

BUG=678359
==========

to

==========
Let the canonical name of invalid encoding be an empty string

Returning nullptr caused crash in fuzz testing when the call sites 
attempts to create a string object out of it. Previously it was
returning an empty string(std::string()). This change makes it work
as it used to by returning a string literal.

BUG=678359
==========

[Jinsuk Kim, 2017-01-06 01:55:31]

jinsukkim@chromium.org changed reviewers:
+ dcheng@chromium.org, jshin@chromium.org

[dcheng, 2017-01-06 03:33:11]

LGTM

Another alternative is to just return std::string() like the original CL, since
I guess all the callers just assign it to a std::string anyway. I leave it up to
you.

[Jinsuk Kim, 2017-01-06 05:59:47]

Description was changed from

==========
Let the canonical name of invalid encoding be an empty string

Returning nullptr caused crash in fuzz testing when the call sites 
attempts to create a string object out of it. Previously it was
returning an empty string(std::string()). This change makes it work
as it used to by returning a string literal.

BUG=678359
==========

to

==========
Let the canonical name of invalid encoding be an empty string

Returning nullptr caused crash in fuzz testing when the call sites 
attempts to create a string object out of it. Previously it was
returning an empty string(std::string()). This change makes it work
as it used to by changing the return type back to std::string.

BUG=678359
==========

[Jinsuk Kim, 2017-01-06 06:00:26]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 06:00:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jinsuk Kim, 2017-01-06 06:12:48]

On 2017/01/06 03:33:11, dcheng wrote:
> LGTM
> 
> Another alternative is to just return std::string() like the original CL,
since
> I guess all the callers just assign it to a std::string anyway. I leave it up
to
> you.

I prefer returning std::string. Thanks.

[dcheng, 2017-01-06 06:27:42]

still lgtm. sorry for the bad advice in the original CL

[commit-bot: I haz the power, 2017-01-06 07:01:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 07:01:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Jinsuk Kim, 2017-01-06 07:10:17]

The CQ bit was checked by jinsukkim@chromium.org

[commit-bot: I haz the power, 2017-01-06 07:10:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 08:16:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483686617951130,
"parent_rev": "87b724b37d6da750c2a052e88bf828bd75ab4de0", "commit_rev":
"8e9a8aabbde296324fa081995177dd5aac5622e4"}

[commit-bot: I haz the power, 2017-01-06 08:17:21]

Description was changed from

==========
Let the canonical name of invalid encoding be an empty string

Returning nullptr caused crash in fuzz testing when the call sites 
attempts to create a string object out of it. Previously it was
returning an empty string(std::string()). This change makes it work
as it used to by changing the return type back to std::string.

BUG=678359
==========

to

==========
Let the canonical name of invalid encoding be an empty string

Returning nullptr caused crash in fuzz testing when the call sites 
attempts to create a string object out of it. Previously it was
returning an empty string(std::string()). This change makes it work
as it used to by changing the return type back to std::string.

BUG=678359

Review-Url: https://codereview.chromium.org/2619493002
Cr-Commit-Position: refs/heads/master@{#441904}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e9a8aabbde296324fa081995177...
==========

[commit-bot: I haz the power, 2017-01-06 08:17:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e9a8aabbde296324fa081995177...