Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2619483002: Cleanup in FullscreenController. (Closed)

Created:
3 years, 11 months ago by michaeldo
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup in FullscreenController. BUG=none Review-Url: https://codereview.chromium.org/2619483002 Cr-Commit-Position: refs/heads/master@{#442954} Committed: https://chromium.googlesource.com/chromium/src/+/8e0401b98b04efa30126510b030558b3b23a1e70

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ios/chrome/browser/ui/fullscreen_controller.mm View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
michaeldo
3 years, 11 months ago (2017-01-06 00:11:47 UTC) #1
michaeldo
3 years, 11 months ago (2017-01-10 16:57:42 UTC) #3
rohitrao (ping after 24h)
lgtm https://codereview.chromium.org/2619483002/diff/1/ios/chrome/browser/ui/fullscreen_controller.mm File ios/chrome/browser/ui/fullscreen_controller.mm (right): https://codereview.chromium.org/2619483002/diff/1/ios/chrome/browser/ui/fullscreen_controller.mm#newcode295 ios/chrome/browser/ui/fullscreen_controller.mm:295: // TODO(crbug.com/451373): Evaluate using listener instead of notifications. ...
3 years, 11 months ago (2017-01-10 17:24:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619483002/20001
3 years, 11 months ago (2017-01-11 17:58:52 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 18:11:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e0401b98b04efa30126510b0305...

Powered by Google App Engine
This is Rietveld 408576698