Group Downloads notifications, and separate Incognito

Group Downloads notifications, and separate Incognito

* Download notifications are grouped together, and Incognito
  is put into its own group.  Summary notifications will come
  in a later patch; Android N doesn't seem to bundle these
  together once they're in their own group, making it hard
  to debug without Android Wear.

* New and existing group name constants are moved into
  NotificationConstants.java.

* Cleans up DownloadNotificationService's constant naming
  schemes to make it clearer what each field does.

BUG=678694, 674015
Review-Url: https://codereview.chromium.org/2619433003
Cr-Commit-Position: refs/heads/master@{#442017}
Committed: https://chromium.googlesource.com/chromium/src/+/318c5ae5cb37a664c2f068fa2095d293bfc50bcd

[gone, 2017-01-06 00:26:22]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 00:27:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 01:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 01:03:58]

Dry run: This issue passed the CQ dry run.

[gone, 2017-01-06 02:11:07]

dfalcantara@chromium.org changed reviewers:
+ mlamouri@chromium.org, qinmin@chromium.org, tedchoc@chromium.org

[gone, 2017-01-06 02:11:08]

Min for downloads changes, Mounir for media changes, Ted for incognito changes.

[whywhat, 2017-01-06 02:17:26]

avayvod@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2017-01-06 02:17:26]

MediaNotificationManager lgtm

https://codereview.chromium.org/2619433003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
(right):

https://codereview.chromium.org/2619433003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java:64:
public static final String NOTIFICATION_GROUP_DOWNLOADS = "Downloads";
nit: maybe remove NOTIFICATION from the names to make them shorter? they will be
prefixed with NotificationConstants anyway.

[mlamouri (slow - plz ping), 2017-01-06 09:51:00]

lgtm

[Ted C, 2017-01-06 17:16:23]

On 2017/01/06 09:51:00, mlamouri wrote:
> lgtm

incognito - lgtm

[gone, 2017-01-06 18:34:08]

https://codereview.chromium.org/2619433003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
(right):

https://codereview.chromium.org/2619433003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java:64:
public static final String NOTIFICATION_GROUP_DOWNLOADS = "Downloads";
On 2017/01/06 02:17:26, whywhat wrote:
> nit: maybe remove NOTIFICATION from the names to make them shorter? they will
be
> prefixed with NotificationConstants anyway.

Done.

[gone, 2017-01-06 18:35:13]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:35:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qinmin, 2017-01-06 19:40:29]

lgtm

[gone, 2017-01-06 19:42:09]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2017-01-06 19:42:11]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2017-01-06 19:42:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, avayvod@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2619433003/#ps20001
(title: "Comments")

[commit-bot: I haz the power, 2017-01-06 19:42:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 20:04:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483731731512060,
"parent_rev": "ca86c9e8f039783ad8b5f255995cb79b2a7287bf", "commit_rev":
"318c5ae5cb37a664c2f068fa2095d293bfc50bcd"}

[commit-bot: I haz the power, 2017-01-06 20:04:31]

Description was changed from

==========
Group Downloads notifications, and separate Incognito

* Download notifications are grouped together, and Incognito
  is put into its own group.  Summary notifications will come
  in a later patch; Android N doesn't seem to bundle these
  together once they're in their own group, making it hard
  to debug without Android Wear.

* New and existing group name constants are moved into
  NotificationConstants.java.

* Cleans up DownloadNotificationService's constant naming
  schemes to make it clearer what each field does.

BUG=678694,674015
==========

to

==========
Group Downloads notifications, and separate Incognito

* Download notifications are grouped together, and Incognito
  is put into its own group.  Summary notifications will come
  in a later patch; Android N doesn't seem to bundle these
  together once they're in their own group, making it hard
  to debug without Android Wear.

* New and existing group name constants are moved into
  NotificationConstants.java.

* Cleans up DownloadNotificationService's constant naming
  schemes to make it clearer what each field does.

BUG=678694,674015

Review-Url: https://codereview.chromium.org/2619433003
Cr-Commit-Position: refs/heads/master@{#442017}
Committed:
https://chromium.googlesource.com/chromium/src/+/318c5ae5cb37a664c2f068fa2095...
==========

[commit-bot: I haz the power, 2017-01-06 20:04:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/318c5ae5cb37a664c2f068fa2095...