Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 2619383003: Add a separate Variations.FirstRun.SeedConnectTime histogram. (Closed)

Created:
3 years, 11 months ago by Alexei Svitkine (slow)
Modified:
3 years, 11 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a separate Variations.FirstRun.SeedConnectTime histogram. The Java API to fetch histograms provides several timeout values we can set - specifically, the connect time timeout can be set separately. Add a separate histogram to measure this to understand what the data from the wild is like - especially on slow connections. BUG=632199 Review-Url: https://codereview.chromium.org/2619383003 Cr-Commit-Position: refs/heads/master@{#442635} Committed: https://chromium.googlesource.com/chromium/src/+/62a04af63277f7b2e55c50dde633080c7ad132a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedService.java View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Alexei Svitkine (slow)
3 years, 11 months ago (2017-01-09 22:55:43 UTC) #2
rkaplow
lgtm
3 years, 11 months ago (2017-01-10 18:23:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619383003/1
3 years, 11 months ago (2017-01-10 18:24:33 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 18:30:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/62a04af63277f7b2e55c50dde633...

Powered by Google App Engine
This is Rietveld 408576698