Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2619363004: RELAND: ONC: Fix handling of invalid proxy scheme. (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
Reviewers:
Peter Kasting, emaxx
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RELAND: ONC: Fix handling of invalid proxy scheme. Original CL: https://codereview.chromium.org/2608803002/ PS 2 fixes chromeos_unittests. It is common for a proxy configuration URL to be added as 'foo.com' instead of 'http://foo.com'. Rather than relying on all UI to validate the input, we should do so in the ONC conversion. BUG=677357 TBR=emaxx@chromium.org,pkasting@chromium.org Review-Url: https://codereview.chromium.org/2619363004 Cr-Commit-Position: refs/heads/master@{#442697} Committed: https://chromium.googlesource.com/chromium/src/+/ffe695ceccba7953f426334c81915cc9eb5484ee

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M chromeos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/network/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/network/onc/onc_utils.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_utils_unittest.cc View 1 1 chunk +18 lines, -7 lines 0 comments Download
A chromeos/test/data/network/proxy_config_from_onc.json View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619363004/20001
3 years, 11 months ago (2017-01-10 20:10:09 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 21:36:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ffe695ceccba7953f426334c8191...

Powered by Google App Engine
This is Rietveld 408576698