Track SDP parse errors for SLD in chrome://webrtc-internals

Track SDP parse errors for SLD in chrome://webrtc-internals

Just the SLD-equivalent of:
https://codereview.chromium.org/2622453002

Also adds tests.

BUG=chromium:677550
Review-Url: https://codereview.chromium.org/2619343003
Cr-Commit-Position: refs/heads/master@{#442766}
Committed: https://chromium.googlesource.com/chromium/src/+/536b626025606ce4ecca3f2595d384cd4b947ebe

[Taylor_Brandstetter, 2017-01-10 00:32:46]

deadbeef@chromium.org changed reviewers:
+ eae@chromium.org, hbos@chromium.org

[Taylor_Brandstetter, 2017-01-10 00:32:46]

hbos@chromium.org: Please review changes in content/renderer/

eae@chromium.org: Please review changes in third_party/WebKit/Source/platform/.
The issue is that I need to construct a WebRTCVoidRequest for testing, and call
"requestFailed" on it. But it asserts if "m_private" is null, and there's no way
from that test to construct a WebRTCVoidRequest with "m_private" not set to
null. Is there a preferred solution for this kind of situation?

[hbos_chromium, 2017-01-10 09:22:40]

On 2017/01/10 00:32:46, Taylor_Brandstetter wrote:
> mailto:hbos@chromium.org: Please review changes in content/renderer/
> 
> mailto:eae@chromium.org: Please review changes in
third_party/WebKit/Source/platform/.
> The issue is that I need to construct a WebRTCVoidRequest for testing, and
call
> "requestFailed" on it. But it asserts if "m_private" is null, and there's no
way
> from that test to construct a WebRTCVoidRequest with "m_private" not set to
> null. Is there a preferred solution for this kind of situation?

content/renderer/ lgtm.

[eae, 2017-01-10 21:58:35]

OK, LGTM

[Taylor_Brandstetter, 2017-01-10 22:05:23]

The CQ bit was checked by deadbeef@chromium.org

[commit-bot: I haz the power, 2017-01-10 22:06:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 23:34:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 23:34:39]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Taylor_Brandstetter, 2017-01-10 23:44:47]

The CQ bit was checked by deadbeef@chromium.org

[commit-bot: I haz the power, 2017-01-10 23:45:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:12:11]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Taylor_Brandstetter, 2017-01-11 01:14:21]

The CQ bit was checked by deadbeef@chromium.org

[commit-bot: I haz the power, 2017-01-11 01:15:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:47:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484097261613650, "parent_rev":
"28b0c339305fde2065b3d51514d29c1e6280216f", "commit_rev":
"536b626025606ce4ecca3f2595d384cd4b947ebe"}

[commit-bot: I haz the power, 2017-01-11 01:48:09]

Description was changed from

==========
Track SDP parse errors for SLD in chrome://webrtc-internals

Just the SLD-equivalent of:
https://codereview.chromium.org/2622453002

Also adds tests.

BUG=chromium:677550
==========

to

==========
Track SDP parse errors for SLD in chrome://webrtc-internals

Just the SLD-equivalent of:
https://codereview.chromium.org/2622453002

Also adds tests.

BUG=chromium:677550

Review-Url: https://codereview.chromium.org/2619343003
Cr-Commit-Position: refs/heads/master@{#442766}
Committed:
https://chromium.googlesource.com/chromium/src/+/536b626025606ce4ecca3f2595d3...
==========

[commit-bot: I haz the power, 2017-01-11 01:48:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/536b626025606ce4ecca3f2595d3...