Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 2619263002: [x64] Fix code generation of testw and add tests (Closed)

Created:
3 years, 11 months ago by danno
Modified:
3 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Fix code generation of testw and add tests BUG=v8:5798 R=epertoso@chromium.org LOG=N Review-Url: https://codereview.chromium.org/2619263002 Cr-Commit-Position: refs/heads/master@{#42148} Committed: https://chromium.googlesource.com/v8/v8/+/5c15115e8e21ef134457113779f1faac499bc55c

Patch Set 1 #

Patch Set 2 : Correct patch #

Patch Set 3 : Simplify tests #

Patch Set 4 : Fix stuff #

Patch Set 5 : Moar tests #

Patch Set 6 : Re-enable all tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -4 lines) Patch
M src/x64/assembler-x64.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 2 3 4 5 1 chunk +161 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (25 generated)
danno
ptal
3 years, 11 months ago (2017-01-09 14:00:13 UTC) #6
epertoso
lgtm
3 years, 11 months ago (2017-01-09 14:05:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619263002/100001
3 years, 11 months ago (2017-01-09 18:09:23 UTC) #26
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:11:26 UTC) #29
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/5c15115e8e21ef134457113779f1faac499...

Powered by Google App Engine
This is Rietveld 408576698