Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2619253002: Roll DOM Distiller JavaScript distribution package (Closed)

Created:
3 years, 11 months ago by wychen
Modified:
3 years, 11 months ago
Reviewers:
mdjones
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/072fe57b48...aab1a1b038 Picked up changes: aab1a1b Revert "Replace create_standalone_js.py with a custom GWT linker" ac91168 Use stricter comment-detecting heuristics 936bafa Skip <svg> elements when scanning the DOM 315e460 Skip lead image finder when no text content BUG=617360, 658113, 676638 Review-Url: https://codereview.chromium.org/2619253002 Cr-Commit-Position: refs/heads/master@{#442292} Committed: https://chromium.googlesource.com/chromium/src/+/b6bda67c0ddcc984c0f27da39b95fa018fcde652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
wychen
PTAL and land it if it looks good.
3 years, 11 months ago (2017-01-09 13:28:50 UTC) #2
mdjones
lgtm
3 years, 11 months ago (2017-01-09 17:12:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619253002/1
3 years, 11 months ago (2017-01-09 17:13:10 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:11:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6bda67c0ddcc984c0f27da39b95...

Powered by Google App Engine
This is Rietveld 408576698