Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2619233002: Remove ChromeFrameDistribution and ChromeFrameOperations from installer_util. (Closed)

Created:
3 years, 11 months ago by grt (UTC plus 2)
Modified:
3 years, 11 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeFrameDistribution and ChromeFrameOperations from installer_util. BUG=577816 Review-Url: https://codereview.chromium.org/2619233002 Cr-Commit-Position: refs/heads/master@{#442693} Committed: https://chromium.googlesource.com/chromium/src/+/6f65367144842fdae99355bcd3c0b0aa85067122

Patch Set 1 #

Patch Set 2 : sync to position 442533 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -444 lines) Patch
M chrome/installer/util/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/browser_distribution.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/installer/util/chrome_binaries_operations.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/util/chrome_binaries_operations.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/installer/util/chrome_browser_operations.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/util/chrome_browser_operations.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/installer/util/chrome_frame_distribution.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/installer/util/chrome_frame_distribution.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/installer/util/chrome_frame_operations.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/installer/util/chrome_frame_operations.cc View 1 chunk +0 lines, -142 lines 0 comments Download
M chrome/installer/util/product.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/installer/util/product.cc View 4 chunks +1 line, -10 lines 0 comments Download
M chrome/installer/util/product_operations.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/installer/util/product_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/util_constants.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
grt (UTC plus 2)
Hi Robert. Thought you might find this one fun to review. :-) Feel free to ...
3 years, 11 months ago (2017-01-09 14:59:51 UTC) #6
robertshield
Welp, there it goes. LGTM
3 years, 11 months ago (2017-01-09 16:34:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619233002/20001
3 years, 11 months ago (2017-01-10 21:16:06 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 21:23:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6f65367144842fdae99355bcd3c0...

Powered by Google App Engine
This is Rietveld 408576698