Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2619223002: [ARM] Add get_q_register, set_q_register overloads for NEON instructions. (Closed)

Created:
3 years, 11 months ago by bbudge
Modified:
3 years, 11 months ago
Reviewers:
martyn.capewell
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM] Add get_q_register, set_q_register overloads for NEON instructions. Adds overloads for float, int32, int16, uint16, int8 and uint8 arrays. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2619223002 Cr-Commit-Position: refs/heads/master@{#42153} Committed: https://chromium.googlesource.com/v8/v8/+/ab14a1360104b815470cc06a5b600a057de6d5be

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Patch Set 3 : Remove unnecessary overloads. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -159 lines) Patch
M src/arm/simulator-arm.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 2 14 chunks +174 lines, -155 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
bbudge
3 years, 11 months ago (2017-01-09 12:44:25 UTC) #6
martyn.capewell
https://codereview.chromium.org/2619223002/diff/1/src/arm/simulator-arm.h File src/arm/simulator-arm.h (right): https://codereview.chromium.org/2619223002/diff/1/src/arm/simulator-arm.h#newcode154 src/arm/simulator-arm.h:154: void get_q_register(int qreg, uint64_t* value); Are these uint64_t* specialised ...
3 years, 11 months ago (2017-01-09 14:30:02 UTC) #9
bbudge
https://codereview.chromium.org/2619223002/diff/1/src/arm/simulator-arm.h File src/arm/simulator-arm.h (right): https://codereview.chromium.org/2619223002/diff/1/src/arm/simulator-arm.h#newcode154 src/arm/simulator-arm.h:154: void get_q_register(int qreg, uint64_t* value); On 2017/01/09 14:30:02, martyn.capewell ...
3 years, 11 months ago (2017-01-09 18:33:26 UTC) #14
martyn.capewell
lgtm
3 years, 11 months ago (2017-01-09 18:51:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619223002/20002
3 years, 11 months ago (2017-01-09 23:08:27 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 23:10:14 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:20002) as
https://chromium.googlesource.com/v8/v8/+/ab14a1360104b815470cc06a5b600a057de...

Powered by Google App Engine
This is Rietveld 408576698