Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2619203002: [serializer] pass internal fields deserializer callback as argument. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] pass internal fields deserializer callback as argument. Background to this is that blink needs to be able to pass different internal fields deserialization callbacks for individual to-be-deserialized contexts. R=jochen@chromium.org, peria@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2619203002 Cr-Commit-Position: refs/heads/master@{#42132} Committed: https://chromium.googlesource.com/v8/v8/+/081193d5b14a1481849d9bb4ada45e3c39bb1075

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -100 lines) Patch
M include/v8.h View 6 chunks +11 lines, -12 lines 0 comments Download
M src/api.cc View 14 chunks +32 lines, -25 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +14 lines, -7 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/snapshot/deserializer.h View 2 chunks +5 lines, -3 lines 0 comments Download
M src/snapshot/deserializer.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/snapshot/partial-serializer.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/snapshot/snapshot.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/snapshot-common.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 13 chunks +20 lines, -36 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Yang
3 years, 11 months ago (2017-01-09 09:26:06 UTC) #1
peria
Thanks. LGTM
3 years, 11 months ago (2017-01-09 09:53:24 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-09 09:54:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619203002/1
3 years, 11 months ago (2017-01-09 10:10:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/081193d5b14a1481849d9bb4ada45e3c39bb1075
3 years, 11 months ago (2017-01-09 10:12:13 UTC) #12
peria
3 years, 11 months ago (2017-01-10 08:14:58 UTC) #13
Message was sent while issue was closed.
I found that we couldn't bind pointers with DeserializeInternalFieldsCallback,
because it is a "function".
It should be a callback object (e.g. std::function<>) to be bind with some
values.
Could you change the APIs again?
(I want a change like https://codereview.chromium.org/2620933002/)

Powered by Google App Engine
This is Rietveld 408576698