Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2619163005:
Add domxpath/xml_xpath_tests.xml to list of files to skip when updating WPT. (Closed)
DescriptionAdd domxpath/xml_xpath_tests.xml to list of files to skip when updating WPT.
This file is too large to upload to Rietveld. This is just a quick fix CL for this particular case of a large file.
NOEXPORT=true
BUG=676491
Review-Url: https://codereview.chromium.org/2619163005
Cr-Commit-Position: refs/heads/master@{#442841}
Committed: https://chromium.googlesource.com/chromium/src/+/e71e4c5f1355e8937d59728476ef1e1eef170b06
Patch Set 1 #Patch Set 2 : Skip xml_xpath_tests.xml (very large file, cannot be uploaded to Rietveld) #Messages
Total messages: 20 (15 generated)
qyearsley@chromium.org changed reviewers: + jsbell@chromium.org
The last WPT auto-import (https://codereview.chromium.org/2626563003) failed after apparently uploading a CL with no changes -- haven't yet figured out exactly why that is. After running `update-w3c-deps wpt` locally, I got this change; I didn't spot any problems with it :-/
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Description was changed from ========== Import wpt@dc3eba22286488a5acd2653763d8ce4b8c77f99c Using update-w3c-deps in Chromium d8b62ea53246ab528786b9a8d312d0a3733e46e9. ========== to ========== Import wpt@dc3eba22286488a5acd2653763d8ce4b8c77f99c Using update-w3c-deps in Chromium d8b62ea53246ab528786b9a8d312d0a3733e46e9. NOEXPORT=true ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/01/10 at 20:49:46, qyearsley wrote: > The last WPT auto-import (https://codereview.chromium.org/2626563003) failed after apparently uploading a CL with no changes -- haven't yet figured out exactly why that is. After running `update-w3c-deps wpt` locally, I got this change; I didn't spot any problems with it :-/ Update: Now I see that Now I'm pretty sure that the reason why it failed before was because it included a file that was too large to upload to Rietveld; now skipped. Patch 1 of this CL failed the presubmit because the changes to the IndexedDB tests were already made in https://codereview.chromium.org/2624663003.
Description was changed from ========== Import wpt@dc3eba22286488a5acd2653763d8ce4b8c77f99c Using update-w3c-deps in Chromium d8b62ea53246ab528786b9a8d312d0a3733e46e9. NOEXPORT=true ========== to ========== Add domxpath/xml_xpath_tests.xml to list of files to skip when updating WPT. This file is too large to upload to Rietveld. This is just a quick fix CL for this particular case of a large file. NOEXPORT=true BUG=676491 ==========
qyearsley@chromium.org changed reviewers: + dominicc@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dominicc@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 10001, "attempt_start_ts": 1484121633063330,
"parent_rev": "46ad8afa30fb005f534fc13e40acbe1e0f0f4787", "commit_rev":
"e71e4c5f1355e8937d59728476ef1e1eef170b06"}
Message was sent while issue was closed.
Description was changed from ========== Add domxpath/xml_xpath_tests.xml to list of files to skip when updating WPT. This file is too large to upload to Rietveld. This is just a quick fix CL for this particular case of a large file. NOEXPORT=true BUG=676491 ========== to ========== Add domxpath/xml_xpath_tests.xml to list of files to skip when updating WPT. This file is too large to upload to Rietveld. This is just a quick fix CL for this particular case of a large file. NOEXPORT=true BUG=676491 Review-Url: https://codereview.chromium.org/2619163005 Cr-Commit-Position: refs/heads/master@{#442841} Committed: https://chromium.googlesource.com/chromium/src/+/e71e4c5f1355e8937d59728476ef... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:10001) as https://chromium.googlesource.com/chromium/src/+/e71e4c5f1355e8937d59728476ef... |
