Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2619163002: More early returns in GeometryMapper methods (Closed)

Created:
3 years, 11 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
pdr., chrishtr
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More early returns in GeometryMapper methods This can get the same performance for paint invalidation as https://codereview.chromium.org/2621483002/, but it will also improve performances of other public methods. BUG=678597 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2619163002 Cr-Commit-Position: refs/heads/master@{#442491} Committed: https://chromium.googlesource.com/chromium/src/+/ae5695364d1c6e0cdefcad92302959cfa8b43274

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp View 1 2 12 chunks +33 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp View 1 2 1 chunk +12 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (15 generated)
Xianzhu
3 years, 11 months ago (2017-01-09 23:04:48 UTC) #4
pdr.
LGTM
3 years, 11 months ago (2017-01-09 23:11:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619163002/40001
3 years, 11 months ago (2017-01-10 03:59:59 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 05:14:29 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ae5695364d1c6e0cdefcad923029...

Powered by Google App Engine
This is Rietveld 408576698