Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2619103002: android: Use Display in thumbnail_cache (Closed)

Created:
3 years, 11 months ago by boliu
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Use Display in thumbnail_cache Get the primary display to get the display dimensions, which removes dependency on the deprecated DeviceDisplayInfo. BUG=625089 Review-Url: https://codereview.chromium.org/2619103002 Cr-Commit-Position: refs/heads/master@{#442123} Committed: https://chromium.googlesource.com/chromium/src/+/02c81cd8f5b5ee59289345c3c73f2953c5708b9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/android/thumbnail/thumbnail_cache.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
boliu
ptal
3 years, 11 months ago (2017-01-07 00:15:16 UTC) #6
Ted C
lgtm
3 years, 11 months ago (2017-01-07 00:52:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619103002/1
3 years, 11 months ago (2017-01-07 00:55:21 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 01:06:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02c81cd8f5b5ee59289345c3c73f...

Powered by Google App Engine
This is Rietveld 408576698