s390: Fix FunctionBodyDecoderTest to compile with gcc4.8.5

s390: Fix FunctionBodyDecoderTest to compile with gcc4.8.5

GCC4.8.5 on s390 emits warning "array subscript is above array bounds"
for line "code[pos + 1] = kLocalVoid;". The warning seems to be
correct because code[sizeof(code)] should be out of bounds.
I'm suggesting to run the loop till "sizeof(code) - 1" which GCC(4.8.5)
agrees with. Although this means the last byte is missed, but it should
be safe to do since the last few bytes are "0xb" (kExprEnd) and the
offending statement is only run when byte=kExprBlock.

R=titzer@chromium.org, mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2619063002
Cr-Commit-Position: refs/heads/master@{#42145}
Committed: https://chromium.googlesource.com/v8/v8/+/e7fc42796c823fdee6b4f812f798679df42fba0c

[JaideepBajwa, 2017-01-06 22:04:16]

ptal

[bradnelson, 2017-01-09 07:12:32]

lgtm

https://codereview.chromium.org/2619063002/diff/1/test/unittests/wasm/functio...
File test/unittests/wasm/function-body-decoder-unittest.cc (right):

https://codereview.chromium.org/2619063002/diff/1/test/unittests/wasm/functio...
test/unittests/wasm/function-body-decoder-unittest.cc:1857: for (size_t pos = 0;
pos < (sizeof(code) - 1); pos++) {
parens needed?

[titzer, 2017-01-09 08:54:39]

lgtm

[JaideepBajwa, 2017-01-09 14:35:33]

On 2017/01/09 07:12:32, bradnelson wrote:
> lgtm
> 
>
https://codereview.chromium.org/2619063002/diff/1/test/unittests/wasm/functio...
> File test/unittests/wasm/function-body-decoder-unittest.cc (right):
> 
>
https://codereview.chromium.org/2619063002/diff/1/test/unittests/wasm/functio...
> test/unittests/wasm/function-body-decoder-unittest.cc:1857: for (size_t pos =
0;
> pos < (sizeof(code) - 1); pos++) {
> parens needed?

updated, thanks!

[JaideepBajwa, 2017-01-09 14:35:38]

The CQ bit was checked by bjaideep@ca.ibm.com

[JaideepBajwa, 2017-01-09 14:35:38]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2619063002/#ps20001
(title: "removed unnecessary parenthesis")

[commit-bot: I haz the power, 2017-01-09 14:35:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 15:20:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483972538457910,
"parent_rev": "63952fd498cd56d3dfb071aabc5ac0d06ae5a3d9", "commit_rev":
"e7fc42796c823fdee6b4f812f798679df42fba0c"}

[commit-bot: I haz the power, 2017-01-09 15:20:19]

Description was changed from

==========
s390: Fix FunctionBodyDecoderTest to compile with gcc4.8.5

GCC4.8.5 on s390 emits warning "array subscript is above array bounds"
for line "code[pos + 1] = kLocalVoid;". The warning seems to be
correct because code[sizeof(code)] should be out of bounds.
I'm suggesting to run the loop till "sizeof(code) - 1" which GCC(4.8.5)
agrees with. Although this means the last byte is missed, but it should
be safe to do since the last few bytes are "0xb" (kExprEnd) and the
offending statement is only run when byte=kExprBlock.

R=titzer@chromium.org, mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
LOG=N
==========

to

==========
s390: Fix FunctionBodyDecoderTest to compile with gcc4.8.5

GCC4.8.5 on s390 emits warning "array subscript is above array bounds"
for line "code[pos + 1] = kLocalVoid;". The warning seems to be
correct because code[sizeof(code)] should be out of bounds.
I'm suggesting to run the loop till "sizeof(code) - 1" which GCC(4.8.5)
agrees with. Although this means the last byte is missed, but it should
be safe to do since the last few bytes are "0xb" (kExprEnd) and the
offending statement is only run when byte=kExprBlock.

R=titzer@chromium.org, mstarzinger@chromium.org, bradnelson@chromium.org
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2619063002
Cr-Commit-Position: refs/heads/master@{#42145}
Committed:
https://chromium.googlesource.com/v8/v8/+/e7fc42796c823fdee6b4f812f798679df42...
==========

[commit-bot: I haz the power, 2017-01-09 15:20:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e7fc42796c823fdee6b4f812f798679df42...