Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2619063002: s390: Fix FunctionBodyDecoderTest to compile with gcc4.8.5 (Closed)

Created:
3 years, 11 months ago by JaideepBajwa
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, JoranSiu, john.yan, michael_dawson, jbarboza
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: Fix FunctionBodyDecoderTest to compile with gcc4.8.5 GCC4.8.5 on s390 emits warning "array subscript is above array bounds" for line "code[pos + 1] = kLocalVoid;". The warning seems to be correct because code[sizeof(code)] should be out of bounds. I'm suggesting to run the loop till "sizeof(code) - 1" which GCC(4.8.5) agrees with. Although this means the last byte is missed, but it should be safe to do since the last few bytes are "0xb" (kExprEnd) and the offending statement is only run when byte=kExprBlock. R=titzer@chromium.org, mstarzinger@chromium.org, bradnelson@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2619063002 Cr-Commit-Position: refs/heads/master@{#42145} Committed: https://chromium.googlesource.com/v8/v8/+/e7fc42796c823fdee6b4f812f798679df42fba0c

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed unnecessary parenthesis #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/unittests/wasm/function-body-decoder-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
JaideepBajwa
ptal
3 years, 11 months ago (2017-01-06 22:04:16 UTC) #1
bradnelson
lgtm https://codereview.chromium.org/2619063002/diff/1/test/unittests/wasm/function-body-decoder-unittest.cc File test/unittests/wasm/function-body-decoder-unittest.cc (right): https://codereview.chromium.org/2619063002/diff/1/test/unittests/wasm/function-body-decoder-unittest.cc#newcode1857 test/unittests/wasm/function-body-decoder-unittest.cc:1857: for (size_t pos = 0; pos < (sizeof(code) ...
3 years, 11 months ago (2017-01-09 07:12:32 UTC) #2
titzer
lgtm
3 years, 11 months ago (2017-01-09 08:54:39 UTC) #3
JaideepBajwa
On 2017/01/09 07:12:32, bradnelson wrote: > lgtm > > https://codereview.chromium.org/2619063002/diff/1/test/unittests/wasm/function-body-decoder-unittest.cc > File test/unittests/wasm/function-body-decoder-unittest.cc (right): > ...
3 years, 11 months ago (2017-01-09 14:35:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619063002/20001
3 years, 11 months ago (2017-01-09 14:35:48 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 15:20:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e7fc42796c823fdee6b4f812f798679df42...

Powered by Google App Engine
This is Rietveld 408576698