Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2619043003: Add HpackDecoderState and HpackDecoderListener. (Closed)

Created:
3 years, 11 months ago by Bence
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add HpackDecoderState and HpackDecoderListener. HpackDecoderState listens to HpackWholeEntryBuffer, resolves indices into the HPACK static and dynamic tables, updates the dynamic table as appropriate, and reports fully decoded header entries to an HpackDecoderListener instance. This CL lands server change 130407086 by jamessynge. BUG=488484 Review-Url: https://codereview.chromium.org/2619043003 Cr-Commit-Position: refs/heads/master@{#443368} Committed: https://chromium.googlesource.com/chromium/src/+/17238c09594d87389b8013e408abf4ad757700bb

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+989 lines, -0 lines) Patch
A net/http2/hpack/decoder/hpack_decoder_listener.h View 1 chunk +65 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_decoder_listener.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_decoder_state.h View 1 chunk +124 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_decoder_state.cc View 1 chunk +215 lines, -0 lines 0 comments Download
A net/http2/hpack/decoder/hpack_decoder_state_test.cc View 1 chunk +548 lines, -0 lines 0 comments Download
M net/net.gypi View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Bence
Biren: PTAL at net/http2/ and net/net.gypi. The net/test/ change will be checked in separately at ...
3 years, 11 months ago (2017-01-08 01:17:46 UTC) #6
Biren Roy
lgtm
3 years, 11 months ago (2017-01-12 17:53:08 UTC) #11
Bence
Ryan: PTAL. Thank you.
3 years, 11 months ago (2017-01-12 18:11:54 UTC) #13
Ryan Hamilton
lgtm
3 years, 11 months ago (2017-01-12 19:55:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619043003/20001
3 years, 11 months ago (2017-01-12 19:56:39 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 21:35:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/17238c09594d87389b8013e408ab...

Powered by Google App Engine
This is Rietveld 408576698