Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2619023002: DevTools: introduce new cm_headless module to fix formatter_worker deps. (Closed)

Created:
3 years, 11 months ago by pfeldman
Modified:
3 years, 11 months ago
Reviewers:
chenwilliam, dgozman, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: introduce new cm_headless module to fix formatter_worker deps. Review-Url: https://codereview.chromium.org/2619023002 Cr-Commit-Position: refs/heads/master@{#442133} Committed: https://chromium.googlesource.com/chromium/src/+/62886b0305bfda888d83046d3972314313522be9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -173 lines) Patch
M third_party/WebKit/Source/devtools/.eslintignore View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 5 chunks +2 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/cm/headlesscodemirror.js View 1 chunk +0 lines, -161 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/cm_headless/headlesscodemirror.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/cm_headless/module.json View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/module.json View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pfeldman
3 years, 11 months ago (2017-01-06 19:54:22 UTC) #2
alph
lgtm
3 years, 11 months ago (2017-01-06 20:01:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619023002/1
3 years, 11 months ago (2017-01-07 00:24:23 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 01:47:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/62886b0305bfda888d83046d3972...

Powered by Google App Engine
This is Rietveld 408576698