Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 26190002: Add --target flag to the chrome_tests.py scripts. (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, Lei Zhang
Visibility:
Public.

Description

Add --target flag to the chrome_tests.py scripts. Currently, --build-dir includes the target (Debug or Release) for these scripts, but in all other scripts --build-dir just points to out / build / xcodebuild. Make the valgrind scripts consistent with that. Enables https://codereview.chromium.org/26184003 . No intended functionality change. BUG=294387 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227309

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M tools/heapcheck/chrome_tests.py View 2 chunks +10 lines, -5 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 2 chunks +15 lines, -9 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
Nico
7 years, 2 months ago (2013-10-06 19:33:13 UTC) #1
Nico
+ma, in case he's around…
7 years, 2 months ago (2013-10-07 00:07:09 UTC) #2
M-A Ruel
lgtm
7 years, 2 months ago (2013-10-07 18:38:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26190002/1
7 years, 2 months ago (2013-10-07 18:43:16 UTC) #4
Alexander Potapenko
LGTM (to avoid interrupting the CQ) with a drive-by nit. https://codereview.chromium.org/26190002/diff/1/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): https://codereview.chromium.org/26190002/diff/1/tools/valgrind/chrome_tests.py#newcode607 ...
7 years, 2 months ago (2013-10-07 18:45:35 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-07 18:51:31 UTC) #6
Nico
On 2013/10/07 18:45:35, Alexander Potapenko wrote: > LGTM (to avoid interrupting the CQ) with a ...
7 years, 2 months ago (2013-10-07 18:52:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26190002/1
7 years, 2 months ago (2013-10-07 18:53:16 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-07 18:54:08 UTC) #9
Message was sent while issue was closed.
Change committed as 227309

Powered by Google App Engine
This is Rietveld 408576698