Move memory waterfall build directory computation to the slave.

Move memory waterfall build directory computation to the slave.

runtest.py already jumps through the right hoops to get the right build_dir
(mostly; but it'll have to learn how to do this completely correct soon),
so just give that an option to pass the build directory on to the memory
scripts.

With this, the isolate master is the last place to call ConvertBuildDirToLegacy
on the master.

Depends on https://codereview.chromium.org/26190002/

BUG=294387
r227327

[M-A Ruel, 2013-10-06 20:32:26]

lgtm

https://codereview.chromium.org/26184003/diff/2001/scripts/slave/runtest.py
File scripts/slave/runtest.py (right):

https://codereview.chromium.org/26184003/diff/2001/scripts/slave/runtest.py#n...
scripts/slave/runtest.py:652: command.append('--build-dir=' + build_dir)
In general I prefer using 2 separate arguments, e.g.
command.extend(('--build-dir', build_dir))
because it'll break on Windows if the string ever get escaped.

There's plenty of other places here that do this so I don't mind, just FYI.

[Nico, 2013-10-06 21:18:52]

Thanks!

If you're still around, do you want to stamp
https://codereview.chromium.org/26190002/ too?


On Sun, Oct 6, 2013 at 1:32 PM, <maruel@chromium.org> wrote:

> lgtm
>
>
> https://codereview.chromium.**org/26184003/diff/2001/**
>
scripts/slave/runtest.py<https://codereview.chromium.org/26184003/diff/2001/scripts/slave/runtest.py>
> File scripts/slave/runtest.py (right):
>
> https://codereview.chromium.**org/26184003/diff/2001/**
>
scripts/slave/runtest.py#**newcode652<https://codereview.chromium.org/26184003/diff/2001/scripts/slave/runtest.py#newcode652>
> scripts/slave/runtest.py:652: command.append('--build-dir=' + build_dir)
> In general I prefer using 2 separate arguments, e.g.
> command.extend(('--build-dir', build_dir))
> because it'll break on Windows if the string ever get escaped.
>
> There's plenty of other places here that do this so I don't mind, just
> FYI.
>
>
https://codereview.chromium.**org/26184003/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-07 19:44:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/26184003/2001

[commit-bot: I haz the power, 2013-10-07 19:45:10]

Presubmit check for 26184003-2001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Pylint (402 files) failed
Traceback (most recent call last):
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 284, in
getattr
    return [self.import_module(name, relative_only=True)]
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 339, in
import_module
    return MANAGER.astng_from_module_name(absmodname)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 136, in
astng_from_module_name
    return self.astng_from_file(filepath, modname, fallback=False)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 107, in
astng_from_file
    return ASTNGBuilder(self).file_build(filepath, modname)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 129, in
file_build
    node = self.string_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 135, in
string_build
    module = self._data_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 151, in
_data_build
    node = parse(data + '\n')
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 41, in parse
    return compile(string, "<string>", 'exec', PyCF_ONLY_AST)
  File "<string>", line 782
    '--pass-build-dir',
                     ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 284, in
getattr
    return [self.import_module(name, relative_only=True)]
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 339, in
import_module
    return MANAGER.astng_from_module_name(absmodname)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 136, in
astng_from_module_name
    return self.astng_from_file(filepath, modname, fallback=False)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 107, in
astng_from_file
    return ASTNGBuilder(self).file_build(filepath, modname)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 129, in
file_build
    node = self.string_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 135, in
string_build
    module = self._data_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 151, in
_data_build
    node = parse(data + '\n')
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 41, in parse
    return compile(string, "<string>", 'exec', PyCF_ONLY_AST)
  File "<string>", line 782
    '--pass-build-dir',
                     ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 284, in
getattr
    return [self.import_module(name, relative_only=True)]
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 339, in
import_module
    return MANAGER.astng_from_module_name(absmodname)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 136, in
astng_from_module_name
    return self.astng_from_file(filepath, modname, fallback=False)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 107, in
astng_from_file
    return ASTNGBuilder(self).file_build(filepath, modname)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 129, in
file_build
    node = self.string_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 135, in
string_build
    module = self._data_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 151, in
_data_build
    node = parse(data + '\n')
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 41, in parse
    return compile(string, "<string>", 'exec', PyCF_ONLY_AST)
  File "<string>", line 782
    '--pass-build-dir',
                     ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 284, in
getattr
    return [self.import_module(name, relative_only=True)]
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 339, in
import_module
    return MANAGER.astng_from_module_name(absmodname)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 136, in
astng_from_module_name
    return self.astng_from_file(filepath, modname, fallback=False)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 107, in
astng_from_file
    return ASTNGBuilder(self).file_build(filepath, modname)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 129, in
file_build
    node = self.string_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 135, in
string_build
    module = self._data_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 151, in
_data_build
    node = parse(data + '\n')
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 41, in parse
    return compile(string, "<string>", 'exec', PyCF_ONLY_AST)
  File "<string>", line 782
    '--pass-build-dir',
                     ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 284, in
getattr
    return [self.import_module(name, relative_only=True)]
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 339, in
import_module
    return MANAGER.astng_from_module_name(absmodname)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 136, in
astng_from_module_name
    return self.astng_from_file(filepath, modname, fallback=False)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 107, in
astng_from_file
    return ASTNGBuilder(self).file_build(filepath, modname)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 129, in
file_build
    node = self.string_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 135, in
string_build
    module = self._data_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 151, in
_data_build
    node = parse(data + '\n')
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 41, in parse
    return compile(string, "<string>", 'exec', PyCF_ONLY_AST)
  File "<string>", line 782
    '--pass-build-dir',
                     ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 284, in
getattr
    return [self.import_module(name, relative_only=True)]
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 339, in
import_module
    return MANAGER.astng_from_module_name(absmodname)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 136, in
astng_from_module_name
    return self.astng_from_file(filepath, modname, fallback=False)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 107, in
astng_from_file
    return ASTNGBuilder(self).file_build(filepath, modname)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 129, in
file_build
    node = self.string_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 135, in
string_build
    module = self._data_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 151, in
_data_build
    node = parse(data + '\n')
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 41, in parse
    return compile(string, "<string>", 'exec', PyCF_ONLY_AST)
  File "<string>", line 782
    '--pass-build-dir',
                     ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 284, in
getattr
    return [self.import_module(name, relative_only=True)]
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 339, in
import_module
    return MANAGER.astng_from_module_name(absmodname)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 136, in
astng_from_module_name
    return self.astng_from_file(filepath, modname, fallback=False)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 107, in
astng_from_file
    return ASTNGBuilder(self).file_build(filepath, modname)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 129, in
file_build
    node = self.string_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 135, in
string_build
    module = self._data_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 151, in
_data_build
    node = parse(data + '\n')
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 41, in parse
    return compile(string, "<string>", 'exec', PyCF_ONLY_AST)
  File "<string>", line 782
    '--pass-build-dir',
                     ^
SyntaxError: invalid syntax
Traceback (most recent call last):
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 284, in
getattr
    return [self.import_module(name, relative_only=True)]
  File "/b/depot_tools/third_party/logilab/astng/scoped_nodes.py", line 339, in
import_module
    return MANAGER.astng_from_module_name(absmodname)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 136, in
astng_from_module_name
    return self.astng_from_file(filepath, modname, fallback=False)
  File "/b/depot_tools/third_party/logilab/astng/manager.py", line 107, in
astng_from_file
    return ASTNGBuilder(self).file_build(filepath, modname)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line 129, in
file_build
    node = self.string_build(data, modname, path)
  File "/b/depot_tools/third_party/logilab/astng/builder.py", line…
(message too large)