Adding swiftshader unittests to GPU FYI bots

Adding swiftshader unittests to GPU FYI bots

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2618933002
Cr-Commit-Position: refs/heads/master@{#443248}
Committed: https://chromium.googlesource.com/chromium/src/+/c9c93b5a51e998ea46dce116486b03b999b344d9

[sugoi1, 2017-01-06 13:23:28]

Description was changed from

==========
Adding swiftshader unittests to GPU FYI bots

BUG=630728
==========

to

==========
Adding swiftshader unittests to GPU FYI bots

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[sugoi1, 2017-01-06 13:24:12]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 13:24:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sugoi1, 2017-01-06 13:24:50]

Description was changed from

==========
Adding swiftshader unittests to GPU FYI bots

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Adding swiftshader unittests to GPU FYI bots

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[sugoi1, 2017-01-06 13:24:50]

sugoi@chromium.org changed reviewers:
+ kbr@chromium.org

[commit-bot: I haz the power, 2017-01-06 14:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 14:08:09]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[sugoi1, 2017-01-11 16:08:04]

The CQ bit was checked by sugoi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 16:08:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 18:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 18:02:23]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-01-11 19:42:06]

lgtm

[sugoi1, 2017-01-11 21:57:49]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2017-01-11 21:58:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:11:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 22:11:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Russell (Google), 2017-01-11 23:08:55]

On 2017/01/11 22:11:56, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

The error is:

** Presubmit Messages **
('run_content_test_gpu_unittests',) (35.24s)

manage (1.24s)

** Presubmit ERRORS **
You need LGTM from owners of depends-on paths in DEPS that were modified in this
CL:
    '+third_party/swiftshader',

Suggested missing target path OWNERS:
    klobag@chromium.org

You should add an OWNERS file to the top level of the SwiftShader repository,
similar to (for example) how third_party/webrtc looks. This change is currently
delegating to the OWNERS of src/third_party.

[sugoi, 2017-01-11 23:32:01]

sugoi@google.com changed reviewers:
+ klobag@chromium.org

[sugoi, 2017-01-11 23:33:02]

sugoi@google.com changed reviewers:
+ sugoi@google.com

[sugoi, 2017-01-11 23:33:03]

Adding klobag@chromium.org as reviewer for missing OWNER in one of the files.

[Ken Russell (switch to Gerrit), 2017-01-12 01:04:50]

On 2017/01/11 23:33:03, sugoi wrote:
> Adding mailto:klobag@chromium.org as reviewer for missing OWNER in one of the
files.

Why don't you just add an OWNERS file to SwiftShader which includes you, and
update the DEPS change here to pull in the new version adding that file?

[sugoi, 2017-01-12 03:00:16]

On 2017/01/12 01:04:50, Ken Russell wrote:
> On 2017/01/11 23:33:03, sugoi wrote:
> > Adding mailto:klobag@chromium.org as reviewer for missing OWNER in one of
the
> files.
> 
> Why don't you just add an OWNERS file to SwiftShader which includes you, and
> update the DEPS change here to pull in the new version adding that file?

Oh! Yeah, sorry, I misread your previous comment. I thought I was missing an
owner for the change in gpu/DEPS.
I will add an OWNER file to SwiftSahder tomorrow.
Thanks.

[sugoi, 2017-01-12 03:01:13]

sugoi@google.com changed reviewers:
- klobag@chromium.org

[sugoi, 2017-01-12 03:01:14]

Removing klobag@ from the reviewers list. Will fix this myself tomorrow.

[sugoi1, 2017-01-12 15:07:39]

The CQ bit was checked by sugoi@chromium.org

[sugoi1, 2017-01-12 15:07:40]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
kbr@google.com
Link to the patchset: https://codereview.chromium.org/2618933002/#ps30001
(title: "Updated to new SwiftShader version which contains an OWNERS file.")

[commit-bot: I haz the power, 2017-01-12 15:07:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 16:11:07]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1484233659591970,
"parent_rev": "ff1de2a101c43ec975180b26fbe320899c4fc4f7", "commit_rev":
"c9c93b5a51e998ea46dce116486b03b999b344d9"}

[commit-bot: I haz the power, 2017-01-12 16:11:40]

Description was changed from

==========
Adding swiftshader unittests to GPU FYI bots

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Adding swiftshader unittests to GPU FYI bots

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2618933002
Cr-Commit-Position: refs/heads/master@{#443248}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9c93b5a51e998ea46dce116486b...
==========

[commit-bot: I haz the power, 2017-01-12 16:11:41]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/c9c93b5a51e998ea46dce116486b...