Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3859)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java

Issue 2618893003: 📰 Tweak the suggestion ranks for UMA to handle fetchMore (Closed)
Patch Set: try skipping UMA for test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
index a0190f41f7137b9deb110cbb95d81fa366ea2421..59ecf6e089e1af7e1d799f0aef3ac365ff17795d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
@@ -15,7 +15,9 @@
import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
+import org.chromium.chrome.browser.suggestions.SuggestionsUma;
+import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
@@ -35,7 +37,8 @@
public SectionList(NewTabPageManager newTabPageManager, OfflinePageBridge offlinePageBridge) {
mNewTabPageManager = newTabPageManager;
- mNewTabPageManager.getSuggestionsSource().setObserver(this);
+ mNewTabPageManager.getSuggestionsSource().init(
+ this, new SuggestionsUma(Collections.unmodifiableMap(mSections)));
mOfflinePageBridge = offlinePageBridge;
resetSections(/* alwaysAllowEmptySections = */ false);
}
@@ -175,17 +178,6 @@ public void onFullRefreshRequired() {
private void setSuggestions(@CategoryInt int category, List<SnippetArticle> suggestions,
@CategoryStatusEnum int status) {
- // Count the number of suggestions before this category.
- int globalPositionOffset = 0;
- for (Map.Entry<Integer, SuggestionsSection> entry : mSections.entrySet()) {
- if (entry.getKey() == category) break;
- globalPositionOffset += entry.getValue().getSuggestionsCount();
- }
- // Assign global indices to the new suggestions.
- for (SnippetArticle suggestion : suggestions) {
- suggestion.mGlobalPosition = globalPositionOffset + suggestion.mPosition;
- }
-
mSections.get(category).addSuggestions(suggestions, status);
}

Powered by Google App Engine
This is Rietveld 408576698