📰 Tweak the suggestion ranks for UMA to handle fetchMore

chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 1d5a8082c671fa145c82b3b447ced5cd12812b71..d2f8082f3f37d31e6f5c33dfad556bc38e595e73 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -329,26 +329,31 @@ private boolean matchURLs(String url1, String url2, boolean matchByHost) {
 
         @Override
         public void trackSnippetsPageImpression(int[] categories, int[] suggestionsPerCategory) {
+            if (sSuggestionsSourceForTests != null) return;

[Bernhard Bauer, 2017/01/11 13:53:38]

Could we instead move these tracking methods into an interface? It could be
SuggestionsSource, or we could add a new interface that SnippetsBridge
implements, to keep SuggestionsSource from blowing up too much.

[dgn, 2017/01/12 14:29:58]

Sure! I was thinking about doing that in another patch at first, but here it
comes anyway :)

             mSnippetsBridge.onPageShown(categories, suggestionsPerCategory);
         }
 
         @Override
         public void trackSnippetImpression(SnippetArticle article) {
+            if (sSuggestionsSourceForTests != null) return;
             mSnippetsBridge.onSuggestionShown(article);
         }
 
         @Override
         public void trackSnippetMenuOpened(SnippetArticle article) {
+            if (sSuggestionsSourceForTests != null) return;
             mSnippetsBridge.onSuggestionMenuOpened(article);
         }
 
         @Override
         public void trackSnippetCategoryActionImpression(int category, int position) {
+            if (sSuggestionsSourceForTests != null) return;
             mSnippetsBridge.onMoreButtonShown(category, position);
         }
 
         @Override
         public void trackSnippetCategoryActionClick(int category, int position) {
+            if (sSuggestionsSourceForTests != null) return;
             mSnippetsBridge.onMoreButtonClicked(category, position);
             switch (category) {
                 case KnownCategories.BOOKMARKS:
@@ -370,7 +375,9 @@ public void trackSnippetCategoryActionClick(int category, int position) {
 
         @Override
         public void openSnippet(int windowOpenDisposition, SnippetArticle article) {
-            mSnippetsBridge.onSuggestionOpened(article, windowOpenDisposition);
+            if (sSuggestionsSourceForTests != null) {
+                mSnippetsBridge.onSuggestionOpened(article, windowOpenDisposition);
+            }
             NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_SNIPPET);
 
             if (article.mIsAssetDownload) {