chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java - Issue 2618893003: 📰 Tweak the suggestion ranks for UMA to handle fetchMore

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

Issue 2618893003: 📰 Tweak the suggestion ranks for UMA to handle fetchMore (Closed)

Patch Set: rebase and fix findbugs warning Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsMetricsReporter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

index 3f3569758af9fcc9f2699b6d745bdfa8ad493561..d2271d97146f547ecd49bae52c043218e4a1a941 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

@@ -94,21 +94,6 @@ public void navigateToRecentTabs() {}

public void navigateToDownloadManager() {}

@Override

- public void trackSnippetsPageImpression(int[] categories, int[] suggestionsPerCategory) {}

- @Override

- public void trackSnippetImpression(SnippetArticle article) {}

- @Override

- public void trackSnippetMenuOpened(SnippetArticle article) {}

- @Override

- public void trackSnippetCategoryActionImpression(int category, int position) {}

- @Override

- public void trackSnippetCategoryActionClick(int category, int position) {}

- @Override

public void openSnippet(int windowOpenDisposition, SnippetArticle article) {}

@Override

@@ -162,6 +147,11 @@ public boolean isCurrentPage() {

public ContextMenuManager getContextMenuManager() {

return mContextMenuManager;

}

+ @Override

+ public SuggestionsMetricsReporter getSuggestionsMetricsReporter() {

+ return mSnippetsBridge;

Bernhard Bauer 2017/01/13 10:56:07 Do we have to handle the SnippetsBridge being dest

dgn 2017/01/13 11:24:04 added snippetsbridge destruction to #onDestroy().

+ }

}

@Override