📰 Tweak the suggestion ranks for UMA to handle fetchMore

chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.suggestions;
 
 import android.content.Context;
 import android.content.Intent;
 import android.os.Bundle;
 import android.view.LayoutInflater;
@@ skipping 76 matching lines @@
         @Override
         public void navigateToBookmarks() {}
 
         @Override
         public void navigateToRecentTabs() {}
 
         @Override
         public void navigateToDownloadManager() {}
 
         @Override
-        public void trackSnippetsPageImpression(int[] categories, int[] suggestionsPerCategory) {}
-
-        @Override
-        public void trackSnippetImpression(SnippetArticle article) {}
-
-        @Override
-        public void trackSnippetMenuOpened(SnippetArticle article) {}
-
-        @Override
-        public void trackSnippetCategoryActionImpression(int category, int position) {}
-
-        @Override
-        public void trackSnippetCategoryActionClick(int category, int position) {}
-
-        @Override
         public void openSnippet(int windowOpenDisposition, SnippetArticle article) {}
 
         @Override
         public void focusSearchBox(boolean beginVoiceSearch, String pastedText) {}
 
         @Override
         public void setMostVisitedURLsObserver(MostVisitedURLsObserver observer, int numResults) {}
 
         @Override
         public void getLocalFaviconImageForURL(
@@ skipping 33 matching lines @@
 
         @Override
         public boolean isCurrentPage() {
             return true;
         }
 
         @Override
         public ContextMenuManager getContextMenuManager() {
             return mContextMenuManager;
         }
+
+        @Override
+        public SuggestionsMetricsReporter getSuggestionsMetricsReporter() {
+            return mSnippetsBridge;

[Bernhard Bauer, 2017/01/13 10:56:07]

Do we have to handle the SnippetsBridge being destroyed?

[dgn, 2017/01/13 11:24:04]

added snippetsbridge destruction to #onDestroy(). getSuggestionsMetricsReporter
is @Nullable, but it looks like the calls are safe, so I think it can stay as it
is. This might have to change when we move to injecting the interfaces where
they are needed rather than pulling from the manager, as we won't be able to see
the reference was nulled. I'll noop them on destroy or something  like that.
Trying to make the patches smaller :/

+        }
     }
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
 
         assert ChromeFeatureList.isEnabled(ChromeFeatureList.NTP_SUGGESTIONS_STANDALONE_UI);
 
         mRecyclerView = (NewTabPageRecyclerView) LayoutInflater.from(this).inflate(
                 R.layout.new_tab_page_recycler_view, null, false);
@@ skipping 18 matching lines @@
     }
 
     @Override
     protected void onDestroy() {
         for (DestructionObserver observer : mDestructionObservers) {
             observer.onDestroy();
         }
         super.onDestroy();
     }
 }