Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5362)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2618893003: 📰 Tweak the suggestion ranks for UMA to handle fetchMore (Closed)
Patch Set: rebase and fix findbugs warning Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
index a1a4e11875be3fdc3e182d8a25d15ffca6e2650b..1b08a8f5a4565e073c70c630cef2a2b65fad7e2d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
@@ -62,14 +62,9 @@ protected void onBindViewHolder(NewTabPageViewHolder holder) {
((ViewHolder) holder).onBindViewHolder(this);
}
- private int getPosition() {
- // TODO(dgn): looks dodgy. Confirm that's what we want.
- return mParentSection.getSuggestionsCount();
- }
-
@VisibleForTesting
void performAction(NewTabPageManager manager) {
- manager.trackSnippetCategoryActionClick(mCategoryInfo.getCategory(), getPosition());
+ manager.getSuggestionsMetricsReporter().onMoreButtonClicked(mCategoryInfo.getCategory());
switch (mCurrentAction) {
case ACTION_VIEW_ALL:
@@ -117,9 +112,8 @@ public void onClick(View v) {
public void onImpression() {
if (mActionListItem != null && !mActionListItem.mImpressionTracked) {
mActionListItem.mImpressionTracked = true;
- manager.trackSnippetCategoryActionImpression(
- mActionListItem.mCategoryInfo.getCategory(),
- mActionListItem.getPosition());
+ manager.getSuggestionsMetricsReporter().onMoreButtonShown(
+ mActionListItem.mCategoryInfo.getCategory());
}
}
});

Powered by Google App Engine
This is Rietveld 408576698