Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2618833003: Update based on new comments for Updating CCT menu item CL after landed (Closed)

Created:
3 years, 11 months ago by ltian
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update based on new comments for Updating CCT menu item CL after landed For "Update CCT/Herb menu item" CL (https://codereview.chromium.org/2596973002), there are some small changes needed after it is landed. This CL updates based on these comments. BUG=None Review-Url: https://codereview.chromium.org/2618833003 Cr-Commit-Position: refs/heads/master@{#441836} Committed: https://chromium.googlesource.com/chromium/src/+/815e35363cf56ac4f91804dede5ec0e2907c6a5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java View 2 chunks +1 line, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
ltian
tedchoc@chromium.org: could you take a look of my changes? Thanks!
3 years, 11 months ago (2017-01-05 23:21:20 UTC) #2
Ted C
lgtm!
3 years, 11 months ago (2017-01-05 23:40:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618833003/1
3 years, 11 months ago (2017-01-06 01:19:22 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:35:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/815e35363cf56ac4f91804dede5e...

Powered by Google App Engine
This is Rietveld 408576698