Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 2618803002: Use master StyleEngine to evaluate MQ in html imports. (Closed)

Created:
3 years, 11 months ago by rune
Modified:
3 years, 11 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, tfarina, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use master StyleEngine to evaluate MQ in html imports. The StyleEngine for html import documents does not have a Frame which means size media queries will always evaluate to true. We incorrectly replaced a passed-in master document StyleEngine with the StyleEngine from the DocumentStyleSheetCollection in https://crrev.com/90d4ea3d That was wrong for evaluating media queries. R=meade@chromium.org BUG=677963 Review-Url: https://codereview.chromium.org/2618803002 Cr-Commit-Position: refs/heads/master@{#441899} Committed: https://chromium.googlesource.com/chromium/src/+/97c98f168ee37c3c114f85fb40cf893e75a4615b

Patch Set 1 #

Patch Set 2 : preferred sheet change broke a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -19 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/media-query-in-html-import.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.h View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 1 4 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
rune
ptal
3 years, 11 months ago (2017-01-05 23:49:30 UTC) #12
meade_UTC10
lgtm
3 years, 11 months ago (2017-01-06 02:43:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618803002/20001
3 years, 11 months ago (2017-01-06 07:51:36 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 07:55:57 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97c98f168ee37c3c114f85fb40cf...

Powered by Google App Engine
This is Rietveld 408576698